Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently viewed is not Space specific #21961

Closed
alexfrancoeur opened this issue Aug 14, 2018 · 4 comments
Closed

Recently viewed is not Space specific #21961

alexfrancoeur opened this issue Aug 14, 2018 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Home Kibana home application Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@alexfrancoeur
Copy link

Recently viewed on Kibana Home currently stores the data in local storage, though it does not seem to be Specific. In the below screenshot I do not have any sample data dashboards / visualizations stored in the Space I am currently in. Clicking on this link results in an error. Is there any way to make sure these links are Space specific in 6.5?

screen shot 2018-08-14 at 11 28 22 am

cc: @nreese @kobelb @legrego @AlonaNadler

@alexfrancoeur alexfrancoeur added bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Home Kibana home application labels Aug 14, 2018
@alexfrancoeur
Copy link
Author

@kobelb @AlonaNadler @legrego is there any way we can get this fixed for the initial spaces release? I imagine it will make for a very confusing experience

@legrego
Copy link
Member

legrego commented Aug 29, 2018

Yep, I'm trying to have this taken care of for the initial release. I'll update here when I have more!

edit: @alexfrancoeur PR is open! #22492

@alexfrancoeur
Copy link
Author

Thanks @legrego!

legrego added a commit that referenced this issue Aug 29, 2018
[skip ci]
This PR makes the "Recently viewed" widget on the Kibana home page space-aware. The widget will only show saved objects that were viewed within the user's current space.

This is accomplished by changing the way the `RecentlyAccessed` module creates its `PersistedLog`. Previously, the `PersistedLog` was using a hard-coded key, but now it is deriving its key based off of the current `basePath`, which contains the space identifier.

I chose this approach because this code lies completely within OSS Kibana, and I did not want to make this module aware of the Spaces plugin. Spaces augments the `basePath` in order to function and construct space-aware links within the UI, so this ends up being transparent to consumers of `chrome.getBasePath`


You'll notice that the `PersistedLog` key is partially hashed. We do this because we don't want the browser to store information about which spaces a particular user may or may not have access to (see this [earlier conversation](#19417 (comment)))


### Important
Installations that have a configured `basePath` other than the default `''` will have their "Recently viewed" list cleared after upgrading to 6.5, because the basePath will become part of the `localStorage` key, when it previously wasn't. While this may _technically_ be a breaking change, I'm hoping this will be acceptable.

Fixes #21961
@legrego
Copy link
Member

legrego commented Aug 29, 2018

Fixed in spaces-phase-1 feature branch by #22492

@legrego legrego closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Home Kibana home application Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

2 participants