Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Ensure we're prepared for dark mode #29100

Closed
chrisronline opened this issue Jan 22, 2019 · 5 comments
Closed

[Monitoring] Ensure we're prepared for dark mode #29100

chrisronline opened this issue Jan 22, 2019 · 5 comments
Assignees
Labels
Team:Monitoring Stack Monitoring team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Jan 22, 2019

Dark mode PR: #28445

We need to ensure the Monitoring app is ready for the K7 upgrade in conjunction with dark mode.

I think most of it is ready with one known outstanding issue: #28610.

Part of this work should also include upgrading to the new SuperDatePicker and that will hopefully help with removing much of our angular code.

@chrisronline chrisronline added the Team:Monitoring Stack Monitoring team label Jan 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@chrisronline
Copy link
Contributor Author

It's likely this will not make 7.0, but come in 7.x

@ryankeairns ryankeairns added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jan 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@ryankeairns
Copy link
Contributor

@chrisronline I think you're safe to close this issue. While your custom header/breadcrumbs would benefit in other ways from being rewritten, they aren't having a negative impact on dark mode here. I'd suggest you close this one and continue to pursue #28610 , separately.

That said, one thing we look out for in SASS files that an cause issues with light/dark mode is hex values. I only see one and it doesn't appear to me that it is actually being applied anywhere at the code:

&.unassigned {
.title {
color: #999;
display: none;
}

@chrisronline
Copy link
Contributor Author

Sounds good! Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

3 participants