-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Ensure we're prepared for dark mode #29100
Comments
Pinging @elastic/stack-monitoring |
It's likely this will not make 7.0, but come in 7.x |
Pinging @elastic/kibana-design |
@chrisronline I think you're safe to close this issue. While your custom header/breadcrumbs would benefit in other ways from being rewritten, they aren't having a negative impact on dark mode here. I'd suggest you close this one and continue to pursue #28610 , separately. That said, one thing we look out for in SASS files that an cause issues with light/dark mode is hex values. I only see one and it doesn't appear to me that it is actually being applied anywhere at the code: Lines 64 to 68 in 96338a7
|
Sounds good! Closing this |
Dark mode PR: #28445
We need to ensure the Monitoring app is ready for the K7 upgrade in conjunction with dark mode.
I think most of it is ready with one known outstanding issue: #28610.
Part of this work should also include upgrading to the new SuperDatePicker and that will hopefully help with removing much of our angular code.
The text was updated successfully, but these errors were encountered: