Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Refactor monitoring top nav #28610

Open
chrisronline opened this issue Jan 11, 2019 · 5 comments
Open

[Monitoring] Refactor monitoring top nav #28610

chrisronline opened this issue Jan 11, 2019 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team

Comments

@chrisronline
Copy link
Contributor

We currently have a custom top nav that should be resolved with newer EUI and Kibana components and services, specifically the new breadcrumb service (#25884) and an EUI date picker (elastic/eui#1351)

@chrisronline chrisronline added enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team labels Jan 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@cachedout
Copy link
Contributor

Moved to 7.1 in Stack Monitoring project.

@chrisronline
Copy link
Contributor Author

This work will most likely go into this effort: #34566

@chrisronline
Copy link
Contributor Author

@igoristic Will this be done with the client side part of NP migration?

@igoristic
Copy link
Contributor

@chrisronline It won't since we're not doing the full React cutover as part of the NP migration anymore. We're kinda stuck with kbn-top-nav directive for now, since we're migrating with angular. Luckily it will be supported in the NP via createTopNavDirective and createTopNavHelper, so we don't have to do it ourselves. We can still use EuiSuperDatePicker if we really want to, but then we'd have to write our own URL/state-management logic (kinda what GlobalState does today). I would rather leave this for when we "re-write" our app to be 100% React, then we can use the context API to handle this with ease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

4 participants