Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Ensure we are showing the cluster name in the breadcrumbs #30087

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Feb 5, 2019

Fixes #30086

In our recent EUI effort in monitoring, it looks like we removed a key line of code for some of our views where we set the cluster on the angular scope properly. This is necessary to make the breadcrumbs work, but rather than going and adding this back, I think we can simply handle it in a single location.

I opted to still set it on the scope incase something else might need it that I don't realize.

Screenshots

screen shot 2019-02-05 at 10 27 25 am

Testing

To test, navigate to various pages in stack monitoring and ensure the cluster name appears after the Clusters in the breadcrumbs.

cc @pickypg

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should backport this fix to 6.6. But also, we should probably stop using Angular scope wherever possible.

@chrisronline
Copy link
Contributor Author

@pickypg Agreed. We'll cover this in #28610

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline
Copy link
Contributor Author

Backport:

6.x: ef6b3c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants