Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] (Accessibility) Screen reader should announce field name as well as type for data visualizer card #31108

Closed
aphelionz opened this issue Feb 14, 2019 · 2 comments · Fixed by #34689
Closed

[ML] (Accessibility) Screen reader should announce field name as well as type for data visualizer card #31108

aphelionz opened this issue Feb 14, 2019 · 2 comments · Fixed by #34689
Assignees
@PhilippBaranovskiy
Labels
Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility v7.2.0 WCAG A

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Navigate to Machine Learning
  2. Navigate to Data Visualizer
  3. Choose "Select an Index Pattern"
  4. Select an index pattern with appropriate data in it
  5. Tab to select a metric from the resulting UI

screenshot_20190214_080112

Actual Result

  1. Screen reader selects # symbol, reads "Number Type"

Expected Result

  1. Screen reader should read the heading of the section

Meta Issue #26855

Kibana Version: 6.5

Relevant WCAG Criteria: 3.3.2 Labels or Instructions
@aphelionz aphelionz changed the title (Accessibility) * When tabbing to a metric in the Metrics section, it only reads "number type". Should read heading (Accessibility) When tabbing to a metric in the Metrics section, it only reads "number type". Should read heading Feb 14, 2019
@aphelionz aphelionz mentioned this issue Feb 14, 2019
Closed
12 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson changed the title (Accessibility) When tabbing to a metric in the Metrics section, it only reads "number type". Should read heading [ML] (Accessibility) Screen reader should announce field name as well as type for data visualizer card Mar 7, 2019
@peteharverson
Copy link
Contributor

Note this applies to all card field types (not just the metric cards), and applies to both the index-based and file data visualizer.

@peteharverson peteharverson mentioned this issue Mar 7, 2019
Closed
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Apr 8, 2019
@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Apr 8, 2019
Merged
1 task
PhilippBaranovskiy added a commit that referenced this issue Apr 15, 2019
@PhilippBaranovskiy
[ML] [Accessibility] Screen reader should announce field name as well…
d830aaf 
… as type for data visualizer card #31108  (#34689)

* card title announce itself including type and name on both data visualize card and indexed stats' cards
* aria labels moved from IconType to FieldTypesUtils; tabIndex moved from IconType to Card's component;
* refactoring ML components, moved some code to field_types_utils.js, rewritten field_type_icon component, tests are adjusted;
@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Apr 15, 2019
Merged
PhilippBaranovskiy added a commit to PhilippBaranovskiy/kibana that referenced this issue Apr 15, 2019
@PhilippBaranovskiy
[ML] [Accessibility] Screen reader should announce field name as well…
efc4e45 
… as type for data visualizer card elastic#31108  (elastic#34689)

* card title announce itself including type and name on both data visualize card and indexed stats' cards
* aria labels moved from IconType to FieldTypesUtils; tabIndex moved from IconType to Card's component;
* refactoring ML components, moved some code to field_types_utils.js, rewritten field_type_icon component, tests are adjusted;
PhilippBaranovskiy added a commit that referenced this issue Apr 15, 2019
@PhilippBaranovskiy
[ML] [Accessibility] Screen reader should announce field name as well…
5399055 
… as type for data visualizer card #31108  (#34689) (#35059)

* card title announce itself including type and name on both data visualize card and indexed stats' cards
* aria labels moved from IconType to FieldTypesUtils; tabIndex moved from IconType to Card's component;
* refactoring ML components, moved some code to field_types_utils.js, rewritten field_type_icon component, tests are adjusted;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippBaranovskiy PhilippBaranovskiy

Labels
Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility v7.2.0 WCAG A
Projects
None yet
Milestone
No milestone
5 participants
@aphelionz @PhilippBaranovskiy @peteharverson @elasticmachine @rayafratkina