Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards with saved searches don't render dark theme correctly on Kibana 6.7.0 #34266

Closed
dougburks opened this issue Apr 1, 2019 · 4 comments
Labels
design Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dougburks
Copy link

dougburks commented Apr 1, 2019

Kibana version:
6.7.0

Elasticsearch version:
6.7.0

Server OS version:
Ubuntu 16.04

Browser version:
Chromium 73

Browser OS version:
Ubuntu 16.04

Original install method (e.g. download page, yum, from source, etc.):
Docker

Describe the bug:
In Kibana 6.5.4, dashboards with saved searches with dark theme render properly.

In Kibana 6.7.0, dashboards with saved searches with dark theme do not render properly. The expanded detail displays in light theme rather than dark theme.

Steps to reproduce:

  1. Create a saved search.
  2. Create a dashboard with dark theme enabled and add the saved search.
  3. Expand one of the documents in the saved search and notice that the detail shows in light theme instead of dark theme.

Expected behavior:
Saved search detail should respect dark theme as it did in previous versions of Kibana.

Screenshots (if relevant):
Here's a screenshot of the proper behavior in Kibana 6.5.4:
kibana-bug-6 5 4-dashboard-saved-search-dark-mode

Here's a screenshot of the improper behavior in Kibana 6.7.0:
Kibana-bug-6 7 0-dashboard-saved-search-dark-mode

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@dougburks dougburks changed the title Dashboards with saved searches don't render dark mode correctly on Kibana 6.7.0 Dashboards with saved searches don't render dark theme correctly on Kibana 6.7.0 Apr 1, 2019
@nickpeihl nickpeihl added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes
Copy link
Contributor

timroes commented Apr 2, 2019

@cchaos do you remember if that was touched by any of the SASS refactorings?

@cchaos
Copy link
Contributor

cchaos commented Apr 5, 2019

Well, everything was touched during the SASS refactors. 😉

In this particular case it looks like a background color was added to the single doc view, not realizing the view also occurred in dark dashboards.

Screen Shot 2019-04-05 at 10 03 27 AM

I can push a quick fix PR, but not sure what the status is for PR's against 6.7.

@timroes
Copy link
Contributor

timroes commented Apr 5, 2019

@cchaos I think since this is a regression from an earlier version and 6.7 will be maintained for over a year, we should release a fix for that in a patch version. If you can put up a PR, I'll highly appreciate that. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants