Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.7] [Regression fix] Add dark theme for doc viewer #34632

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Apr 5, 2019

Fixes #34266

This fixes a dashboard dark mode issue that was introduced here: https://github.com/elastic/kibana/pull/30136/files#diff-fd2de9a5f627f78d20d7cfed48e992df

A background color was added to the single doc view for Discover, not realizing the same view shows up in Dashboards with saved searches.

Before

Screen Shot 2019-04-05 at 10 18 44 AM

After

Screen Shot 2019-04-05 at 10 18 15 AM

@cchaos cchaos requested a review from timroes April 5, 2019 14:23
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link

@emmacunningham emmacunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and code lgtm

@cchaos cchaos merged commit dc714d2 into elastic:6.7 Apr 5, 2019
@cchaos cchaos deleted the 6.7/single-doc-view-dark-mode-fix branch April 5, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants