Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Kibna Logs - Search field does not have a label #40411

Closed
barlowm opened this issue Jul 5, 2019 · 1 comment
Closed

(Accessibility) Kibna Logs - Search field does not have a label #40411

barlowm opened this issue Jul 5, 2019 · 1 comment
Assignees
Labels
Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services WCAG A

Comments

@barlowm
Copy link
Collaborator

barlowm commented Jul 5, 2019

Use Deque axe Browser Extension

Search field does not have a label (A placeholder is not a label). All form input fields require a label.

Fix at least one (1) of these issues:
Add a "aria-label" attribute
Add a aria-labelledby attribute
Add an implicit (wrapped)
Add an explicit
Add a title attribute

Steps to reproduce

  1. Navigate to the Kibana Logs page
  2. Run aXe scan

NoLabel

<div class="euiFlexItem">
	<div class="sc-jTzLTM kGoDGv">
		<div class="euiFormControlLayout euiFormControlLayout--fullWidth">
			<div class="euiFormControlLayout__childrenWrapper">
			<input type="search" placeholder="Search for log entries… (e.g. host.name:host-1)" >
				<div class="euiFormControlLayoutIcons">

Meta Issue
Accessibility Audit for Kibana 7.0

Kibana Version:
7.2

OS:
Tested on Windows 7. But issue exists in all OS's

Browser:
Tested in Chrome. But issue exists in all Browsers

Screen reader: [if relevant]
N/A

Relevant WCAG Criteria: WCAG Criterion

  • 1.3.1 Info and Relationships - Level A
    Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.
  • 3.3.2 Labels or Instructions - Level A
    Labels or instructions are provided when content requires user input

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1

  • ARIA14: Using aria-label to provide an invisible label where a visible label cannot be used
  • ARIA6: Using aria-label to provide labels for objects
@sgrodzicki sgrodzicki added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@Kerry350 Kerry350 self-assigned this Jul 22, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this issue Jul 24, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this issue Aug 2, 2019
* Fixes elastic#40411 - Add aria-label to search input

* Fixes elastic#40425 - Align gear icon aria-labels

* Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel

* Add data-test-subj attribute back for functional test

* Revert "Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel"

This reverts commit 5075777.
Kerry350 added a commit that referenced this issue Aug 5, 2019
* Fixes #40411 - Add aria-label to search input

* Fixes #40425 - Align gear icon aria-labels

* Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel

* Add data-test-subj attribute back for functional test

* Revert "Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel"

This reverts commit 5075777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services WCAG A
Projects
None yet
Development

No branches or pull requests

4 participants