Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interpreter] Failing functional tests on chromedriver 76 #42842

Closed
dmlemeshko opened this issue Aug 7, 2019 · 2 comments
Closed

[interpreter] Failing functional tests on chromedriver 76 #42842

dmlemeshko opened this issue Aug 7, 2019 · 2 comments
Labels
skipped-test test_ui_functional

Comments

@dmlemeshko
Copy link
Member

With #42468 we updated chromedriver to v76 and made following changes:

  • update baseline snapshots to include properties with null values, e.g.
    Replacing {"type":"kibana_context"} with {"filters":null,"query":null,"timeRange":null,"type":"kibana_context"}
  • skip several image-comparison tests, since they constanttly fail

The root cause is not clear and can be tests, Kibana, or both.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

This was referenced Nov 6, 2019
Merged
Closed
Closed
Merged
Dosant added a commit that referenced this issue Nov 21, 2019
@Dosant
Enable expression service screenshot tests (#50472)
cfcac34 
* Enables interpreter screenshot tests which were disabled in #42842
* Refactors tests to use expression service
* Fixes edge cases in expression service render:
** fixes swallowing of promise rejections from renderer.render()
** fixes swallowing of errors which emitted sync in render()
* Adds default value to colorRange type, as otherwise it fails in runtime if not passed
Dosant added a commit to Dosant/kibana that referenced this issue Nov 21, 2019
@Dosant
Enable expression service screenshot tests (elastic#50472)
95d5fa2 
* Enables interpreter screenshot tests which were disabled in elastic#42842
* Refactors tests to use expression service
* Fixes edge cases in expression service render:
** fixes swallowing of promise rejections from renderer.render()
** fixes swallowing of errors which emitted sync in render()
* Adds default value to colorRange type, as otherwise it fails in runtime if not passed
# Conflicts:
#	src/plugins/expressions/public/loader.test.ts
Dosant added a commit that referenced this issue Nov 21, 2019
@Dosant
Enable expression service screenshot tests (#50472) (#51263)
2d633dc 
* Enables interpreter screenshot tests which were disabled in #42842
* Refactors tests to use expression service
* Fixes edge cases in expression service render:
** fixes swallowing of promise rejections from renderer.render()
** fixes swallowing of errors which emitted sync in render()
* Adds default value to colorRange type, as otherwise it fails in runtime if not passed
# Conflicts:
#	src/plugins/expressions/public/loader.test.ts
@Dosant
Copy link
Contributor

Dosant commented Nov 21, 2019

Fixed by #50472

@Dosant Dosant closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skipped-test test_ui_functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dosant @dmlemeshko @elasticmachine