Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare uiExport hacks for New Platform #42984

Closed
8 of 30 tasks
joshdover opened this issue Aug 8, 2019 · 2 comments
Closed
8 of 30 tasks

Prepare uiExport hacks for New Platform #42984

joshdover opened this issue Aug 8, 2019 · 2 comments
Assignees
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

joshdover commented Aug 8, 2019

I've done an audit of all uiExport hacks in our codebase. Some of these must be ported before any NP applications are shipped to users. Sections marked with a ⭐️ fall into this category.

Needs to be ported ⭐️

Provides a real feature

To be solved by #45427

  • plugins/reporting/hacks/job_completion_notifier

HTTP interceptors

Telemetry

To be solved by #45428

  • plugins/telemetry/hacks/telemetry_init
    • Starts polling for new metrics and sending to backend
  • plugins/telemetry/hacks/telemetry_opt_in
    • Shows opt-in banner for telemetry
  • plugins/ui_metric/hacks/ui_metric_init
    • Inits some telemetry thing, not clear this should be a hack. Needs more investigation

Other

  • plugins/kibana/dev_tools/hacks/hide_empty_tools
    • Hides the dev tools nav link when no tools are registered.

Should be handled by Core ⭐️

Toggle nav link availability

Ideally this behavior could be handled by Chrome itself or by the Licensing Plugin.

To be solved by #45291

  • plugins/graph/hacks/toggle_app_link_in_nav
  • plugins/monitoring/hacks/toggle_app_link_in_nav
  • plugins/timelion/hacks/toggle_app_link_in_nav
  • plugins/ml/hacks/toggle_app_link_in_nav
  • plugins/apm/hacks/toggle_app_link_in_nav
  • plugins/code/hacks/toggle_app_link_in_nav

Should be removed

  • plugins/testbed
    • Just delete this whole plugin
  • plugins/canvas/lib/window_error_handler.js
    • Seems like this should only be in canvas's code
  • plugins/timelion/lib/panel_registry
    • Defines a registry...should not be a hack?

Does not need to be ported

Registries

These shouldn't need to be touched because no NP apps could use these until the registry is migrated to the NP anyways.

  • plugins/console/hacks/register
    • Registers a registry item for dev tools
  • plugins/searchprofiler/register
    • Registers a registry item for dev tools
  • plugins/grokdebugger/sections/grokdebugger/register
    • Registers a registry item for dev tools
  • plugins/timelion/panels/timechart/timechart
    • Registers a panel with above registry

NP shims

These should be safe to ignore.

  • plugins/dashboard_embeddable_container/shim
  • plugins/metrics/public/legacy
  • plugins/tile_map/public/legacy
  • plugins/region_map/public/legacy
  • plugins/vis_type_markdown/public/legacy
  • plugins/vis_type_metric/public/legacy
  • plugins/vis_type_table/public/legacy
  • plugins/vis_type_tagcloud/public/legacy
  • plugins/vis_type_vega/public/legacy
@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Aug 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover
Copy link
Contributor Author

All required hacks needed for NP apps have been migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants