Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate telemetry poller & opt in banner to New Platform #45428

Closed
3 tasks done
joshdover opened this issue Sep 11, 2019 · 7 comments · Fixed by #56285
Closed
3 tasks done

Migrate telemetry poller & opt in banner to New Platform #45428

joshdover opened this issue Sep 11, 2019 · 7 comments · Fixed by #56285
Assignees
Labels
Feature:New Platform Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0

Comments

@joshdover
Copy link
Contributor

joshdover commented Sep 11, 2019

Now that UI applications can be built in the New Platform. We need to move any features provided by uiExport hacks to the New Platform so that they continue to work when no legacy code is on the page.

These telemetry related hacks need to be migrated:

  • plugins/telemetry/hacks/telemetry_init
    • Starts polling for new metrics and sending to backend
  • plugins/telemetry/hacks/telemetry_opt_in
    • Shows opt-in banner for telemetry
  • plugins/ui_metric/hacks/ui_metric_init
    • Inits some telemetry thing, not clear this should be a hack. Needs more investigation

Related to #42984

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform Feature:Telemetry Team:Stack Services labels Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@joshdover
Copy link
Contributor Author

@Bamieh friendly reminder, this is one of the last blockers to allowing plugins to migrate their frontend code to the New Platform. Could we get this resolved in 7.7?

@Bamieh Bamieh added the v7.7.0 label Jan 21, 2020
@Bamieh
Copy link
Member

Bamieh commented Jan 21, 2020

@joshdover Yes I believe we can have it for ready for 7.7. Can you clarify why this would be blocking migration?

@joshdover
Copy link
Contributor Author

When NP apps are mounted on the page, we cannot execute any legacy code (including hacks) because they depend on the global Angular instance in the legacy system.

Therefore, these hacks never get executed when a NP app is mounted. We have a handful of plugins that are ready to move over to the NP (which has the UX improvement of reducing the number of times the user has to wait for Kibana frontend to load). We can't move these over until this functionality is ported so that the opt-in banner shows in these apps and telemetry polling runs when these apps are mounted.

@Bamieh
Copy link
Member

Bamieh commented Jan 21, 2020

Got it. Thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0
Projects
None yet
5 participants