Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Centralized opt in service #48505

Closed
wants to merge 4 commits into from

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Oct 17, 2019

Summary

  • Centralizes Telemetry Opt-in service (used to be in 3 different places (home/license, and telemetry).
  • Moves all vars/configs logic to server.
  • Fixes banner poping up before welcome screen appears.
  • Gets rid of $injector and angular Provider in telemetry to further ease moving to NP.
  • Fixes welcome card example overlay z-index.
  • Gets rid of duplicate fetchTelemetry code.
  • Converts all telemetry plugin code to Typescript 🎉 .
  • Fully migrates public folder to NP

Closes #45428

Remaining:

  • Fix tests
  • Add tests for the new opt-in service
  • Fix kibana when kiaban config telemetry.enabled is set to false

@Bamieh Bamieh added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Oct 17, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Bamieh Bamieh requested a review from a team as a code owner October 17, 2019 17:18
@Bamieh Bamieh requested a review from a team October 17, 2019 17:19
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass changes are minimal. Didn't look beyond the code.

@Bamieh
Copy link
Member Author

Bamieh commented Oct 24, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover
Copy link
Contributor

@Bamieh What's the status here? My main concern is getting those uiExport hacks out of legacy and into the New Platform.

@Bamieh
Copy link
Member Author

Bamieh commented Dec 4, 2019

@joshdover This has been pushed back due to the 7.5.0 release urgent features.

With all the changes introduced to the telemetry repo in the meantime; I believe i'll be closing this PR and cherrypicking files from the branch. I have two PRs migrating things into NP for this week (cloud and ui_metrics), I'll revisit migrating the hacks afterwards.

@Bamieh Bamieh closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate telemetry poller & opt in banner to New Platform
4 participants