Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Expressions] TypeScriptify and Jestify #44197

Closed
25 tasks done
streamich opened this issue Aug 28, 2019 · 2 comments · Fixed by #47212
Closed
25 tasks done

[Expressions] TypeScriptify and Jestify #44197

streamich opened this issue Aug 28, 2019 · 2 comments · Fixed by #47212
Assignees
@streamich
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@streamich
Copy link
Contributor

streamich commented Aug 28, 2019 •
edited
Loading

  • Convert to TypeScript
    • src/legacy/core_plugins/interpreter/server/lib/create_handlers.js
    • src/legacy/core_plugins/interpreter/server/lib/__tests__/create_handlers.js
    • src/legacy/core_plugins/interpreter/server/routes/index.js
    • src/legacy/core_plugins/interpreter/server/routes/server_functions.js
    • src/legacy/core_plugins/interpreter/public/interpreter.test.js
    • src/legacy/core_plugins/interpreter/public/renderers/visualization.js
    • src/legacy/core_plugins/interpreter/public/lib/render_functions_registry.js
    • src/legacy/core_plugins/interpreter/public/lib/render_function.js
    • src/legacy/core_plugins/interpreter/public/functions/visualization.js
    • src/legacy/core_plugins/interpreter/public/functions/index.js
    • src/legacy/core_plugins/interpreter/public/functions/kibana.js
    • src/legacy/core_plugins/interpreter/public/functions/vis_dimension.js
    • src/legacy/core_plugins/interpreter/public/functions/kibana_context.js
    • src/legacy/core_plugins/interpreter/public/functions/__tests__/font.js
    • src/legacy/core_plugins/interpreter/public/functions/kibana.test.js
    • src/legacy/core_plugins/interpreter/public/functions/clog.js
    • src/legacy/core_plugins/interpreter/public/interpreter.js
    • src/legacy/core_plugins/interpreter/test_helpers.js
  • Convert tests to Jest
    • src/legacy/core_plugins/interpreter/public/functions/__tests__/font.js
  • Replace all instances of any and unknown types by correct TypeScript type
    • src/plugins/expressions
    • src/legacy/core_plugins/expressions
    • src/legacy/core_plugins/interpreter/public/

Parent issue: #44153
@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Aug 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich mentioned this issue Aug 28, 2019
Closed
9 tasks
@streamich streamich added 5sp and removed 2sp labels Aug 28, 2019
@streamich streamich self-assigned this Aug 30, 2019
@streamich streamich mentioned this issue Aug 30, 2019
Merged
1 task
@lukeelmers
Copy link
Member

@alexwizp Do you think you could take a look at moving this forward as @streamich will be unavailable for several weeks?

I added a note on the WIP PR about using the ExpressionFunction generic, which I know you are already quite familiar with 😄

Ideally we'd work to get that one merged and then move on to the other items included in the list above.

@streamich streamich changed the title [Expressions] TypeScriptify [Expressions] TypeScriptify and Jestify Sep 27, 2019
This was referenced Oct 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Interpreter TypeScript typings
4 participants
@lukeelmers @streamich @elasticmachine @alexwizp