Improve Interpreter TypeScript typings #47212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:ExpressionLanguage
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
streamich
changed the title
💚 Build Succeeded |
💚 Build Succeeded |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
streamich
commented
Oct 4, 2019
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
ppisljar
requested changes
Oct 7, 2019
src/legacy/core_plugins/expressions/public/expressions/lib/loader.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
💚 Build Succeeded |
streamich
added a commit
that referenced
this pull request
Oct 7, 2019
* fix: 🐛 correct createError() implementation and typings * feat: 🎸 improve expressions service TypeScript types * perf: ⚡️ improve ExpressionLoader class * feat: 🎸 improve Interpreter types * feat: 🎸 improve Interpreter function typings * feat: 🎸 improve Interepreter test TypeScript typings * feat: 🎸 TypeScriptify kibana_context expression function * feat: 🎸 TypeScriptify "kibana" expressions functions * feat: 🎸 TypeScriptify "visualization" function * feat: 🎸 TypeScriptify Interpreter initialization * test: 💍 fix interpreter tests * feat: 🎸 add TypeScript typing to some of the executor internals * fix: 🐛 this fixes visualizations; why? * chore: 🤖 delete redundant files and fix TypeScript error * perf: ⚡️ use not null assertion for .dataHandler * refactor: 💡 stricten AnyExpressionFunction type * fix: 🐛 set correct initial pipeline exec context * feat: 🎸 improve expression type typings * test: 💍 call interpreter with correct input from func tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44197
anyandunknowntypes by correct TypeScript typesrc/plugins/expressionssrc/legacy/core_plugins/expressionssrc/legacy/core_plugins/interpreter/public/