Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert filter_manager/lib to TypeScript / Jest #44952

Closed
2 tasks
lukeelmers opened this issue Sep 5, 2019 · 2 comments · Fixed by #45785
Closed
2 tasks

Convert filter_manager/lib to TypeScript / Jest #44952

lukeelmers opened this issue Sep 5, 2019 · 2 comments · Fixed by #45785
Assignees
@alexwizp
Labels
Feature:Filters Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

  • Convert contents of src/legacy/core_plugins/data/public/filter/filter_manager/lib directory to TS.
  • Remove items from __tests__ and convert to Jest & TS

Consult with @lizozom on any questions.

Part of #44377
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom mentioned this issue Sep 5, 2019
Closed
26 tasks
@lizozom
Copy link
Contributor

lizozom commented Sep 16, 2019

This one might be a bit challenging figuring out the types of Filters
Contact me if you run into any trouble.

@alexwizp alexwizp mentioned this issue Sep 16, 2019
Merged
9 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 18, 2019
@alexwizp
Convert filter_manager/lib to TypeScript / Jest
18137c3 
Fix: elastic#44952
alexwizp added a commit that referenced this issue Sep 27, 2019
@alexwizp
Convert filter_manager/lib to TypeScript / Jest (#45785)
905d021 
* Convert filter_manager/lib to TypeScript / Jest

Fix: #44952

* Update map_query_string.ts

* remove extra ts-ignore

* formatting

* fix PR comments

* Fix PR comments

* fix PR comments

* fix PR comments

* fix merge conflicts

* revert logic

* Fix PR commnets

* add tests for compare_filters

* fix PR comments
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 27, 2019
@alexwizp
Convert filter_manager/lib to TypeScript / Jest (elastic#45785)
30be530 
* Convert filter_manager/lib to TypeScript / Jest

Fix: elastic#44952

* Update map_query_string.ts

* remove extra ts-ignore

* formatting

* fix PR comments

* Fix PR comments

* fix PR comments

* fix PR comments

* fix merge conflicts

* revert logic

* Fix PR commnets

* add tests for compare_filters

* fix PR comments
alexwizp added a commit that referenced this issue Sep 27, 2019
@alexwizp
Convert filter_manager/lib to TypeScript / Jest (#45785) (#46778)
f27d31d 
* Convert filter_manager/lib to TypeScript / Jest

Fix: #44952

* Update map_query_string.ts

* remove extra ts-ignore

* formatting

* fix PR comments

* Fix PR comments

* fix PR comments

* fix PR comments

* fix merge conflicts

* revert logic

* Fix PR commnets

* add tests for compare_filters

* fix PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Filters Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert filter_manager/lib to TypeScript / Jest alexwizp/kibana
4 participants
@lukeelmers @lizozom @elasticmachine @alexwizp