Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable include/exclude in Terms agg for numeric fields #4576

Closed
kurtado opened this issue Aug 3, 2015 · 0 comments · Fixed by #59425
Closed

Enable include/exclude in Terms agg for numeric fields #4576

kurtado opened this issue Aug 3, 2015 · 0 comments · Fixed by #59425
Assignees
@DianaDerevyankina
Labels
Feature:Vis Editor Visualization editor issues good first issue low hanging fruit release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kurtado
Copy link

kurtado commented Aug 3, 2015

As discussed with @spalger, the include/exclude pattern will actually work with numeric fields, although currently in Visualize, it is hidden unless the field being aggregated is a string.
@nreese nreese added good first issue low hanging fruit Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jun 13, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes timroes added Feature:Vis Editor Visualization editor issues and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Mar 3, 2020
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Mar 5, 2020
@DianaDerevyankina
Enable include/exclude in Terms agg for numeric fields
4abf48a 
Closes elastic#4576
@DianaDerevyankina DianaDerevyankina mentioned this issue Mar 5, 2020
Merged
DianaDerevyankina added a commit that referenced this issue Apr 21, 2020
@DianaDerevyankina @elasticmachine
Enable include/exclude in Terms agg for numeric fields (#59425)
46f6f87 
* Enable include/exclude in Terms agg for numeric fields

Closes #4576

* Added a new component that allows adding multiple values

* Added some validation to include/exclude fields

* Removed unnecessary comments and accepted API changes

* Fixed i18n ID issue

* Refactored some code and fixed discard button issue

* Added SimpleNumberList component and value parsing in include_exclude.tsx

* Fixed merge conflict

* Fixed merge conflict

* Refactored some code

* Got rid of lodash isArray, added Number.isFinite where needed and changed symbol of string join and array split

* Added some more test cases to cover migrate_include_exclude_format write method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Apr 21, 2020
@DianaDerevyankina @elasticmachine
Enable include/exclude in Terms agg for numeric fields (elastic#59425)
eaac671 
* Enable include/exclude in Terms agg for numeric fields

Closes elastic#4576

* Added a new component that allows adding multiple values

* Added some validation to include/exclude fields

* Removed unnecessary comments and accepted API changes

* Fixed i18n ID issue

* Refactored some code and fixed discard button issue

* Added SimpleNumberList component and value parsing in include_exclude.tsx

* Fixed merge conflict

* Fixed merge conflict

* Refactored some code

* Got rid of lodash isArray, added Number.isFinite where needed and changed symbol of string join and array split

* Added some more test cases to cover migrate_include_exclude_format write method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit that referenced this issue Apr 21, 2020
@DianaDerevyankina @elasticmachine
Enable include/exclude in Terms agg for numeric fields (#59425) (#64044)
e400469 
* Enable include/exclude in Terms agg for numeric fields

Closes #4576

* Added a new component that allows adding multiple values

* Added some validation to include/exclude fields

* Removed unnecessary comments and accepted API changes

* Fixed i18n ID issue

* Refactored some code and fixed discard button issue

* Added SimpleNumberList component and value parsing in include_exclude.tsx

* Fixed merge conflict

* Fixed merge conflict

* Refactored some code

* Got rid of lodash isArray, added Number.isFinite where needed and changed symbol of string join and array split

* Added some more test cases to cover migrate_include_exclude_format write method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:Vis Editor Visualization editor issues good first issue low hanging fruit release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable include/exclude in Terms agg for numeric fields DianaDerevyankina/kibana
5 participants
@nreese @timroes @kurtado @rashidkpc @DianaDerevyankina