Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Search results #46171

Closed
jfsiii opened this issue Sep 19, 2019 · 2 comments
Closed

[IM] Search results #46171

jfsiii opened this issue Sep 19, 2019 · 2 comments
Assignees
@jfsiii
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Sep 19, 2019 •
edited
Loading

  • Client side filtering
  • Search results replace Your Integrations & Available Integrations sections

From #45562
@jfsiii jfsiii added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Sep 19, 2019
@jfsiii jfsiii self-assigned this Sep 19, 2019
@jfsiii jfsiii mentioned this issue Sep 19, 2019
Closed
9 tasks
@jfsiii jfsiii mentioned this issue Sep 24, 2019
Merged
jfsiii pushed a commit that referenced this issue Sep 30, 2019
[IM] - Search for Integrations. closes #46171 (#46356)
b85febd 
* WIP. Search & Category filters work correctly but built incorrectly.

* Support "0 results found for ..."

* Run renovate script to add js-search

* Break search & integrations apart

* Split header.tsx into header/*.tsx files

Fetch data for search index on start.

* Pull state/data fetching back into Home component

Having the state & fetching (useEffect()) co-located with the view was good for legibility but it lead to unnecessary re-renders as components were (un-,re-)mounted.

Pulled all the fetches back up to Home and passed the data down. Then moved grouped the associated state & useEffect()s together and extracted each as a custom hook.

* Don't style badge text w/ link color. Leave as-is.
@jfsiii
Copy link
Contributor Author

jfsiii commented Oct 4, 2019

closed by #46356

@jfsiii jfsiii closed this as completed Oct 4, 2019
@jasonrhodes jasonrhodes mentioned this issue Oct 4, 2019
Closed
34 tasks
@sgrodzicki sgrodzicki added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Oct 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfsiii jfsiii

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jfsiii @sgrodzicki @jen-huang @elasticmachine