Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Bug in expanded document url-links #48106

Closed
dezwei opened this issue Oct 14, 2019 · 10 comments
Closed

[Discover] Bug in expanded document url-links #48106

dezwei opened this issue Oct 14, 2019 · 10 comments
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0

Comments

@dezwei
Copy link

dezwei commented Oct 14, 2019

Kibana version:
7.4
Elasticsearch version:
7.4
Server OS version:
CentOs 7
Browser version:
Firefox /Chrome
Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):
yum
Describe the bug:
When expanding a document in Discover (url)links are shown as plain text and are not clickable.
In summary of the document, it's shown correctly.
Steps to reproduce:

  1. Set link via Settings->Kibana Index Patterns -> Edit Field-> Url /link
  2. Label Template as {{value}}
  3. Watch a document in discover and expand it

Expected behavior:
Link should only only show {{value}} and it should be clickable
Bug begins to exist in 7.4

@cjcenizal cjcenizal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Oct 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@antcodd
Copy link

antcodd commented Oct 18, 2019

In most cases the URLs display not just as unclickable but as a raw URL <a href>. In some cases the value is just unclickable, possible when there is an array of items.

Here's an example using the Flights example data for some different field types. "Broken URL" is a scripted field.
kibana_url_bug_48106

This also applies to expanded documents in saved search dashboard panels. This is a pretty user unfriendly regression.

@timroes
Copy link
Contributor

timroes commented Oct 18, 2019

cc @kertal could you have a look at this?

@timroes timroes added regression bug Fixes for quality problems that affect the customer experience and removed triage_needed labels Oct 18, 2019
@kertal kertal self-assigned this Oct 18, 2019
@kertal
Copy link
Member

kertal commented Oct 18, 2019

@timroes of course, already was thinking of a good solution for this

@dezwei
Copy link
Author

dezwei commented Oct 18, 2019

If it is in array, the raw HTML link is not even shown. My quick fix for not in array item was looking for a href but is definitely a ugly one.

@kertal kertal mentioned this issue Oct 21, 2019
3 tasks
@kertal
Copy link
Member

kertal commented Oct 23, 2019

will be fixed by #48911 ... and further improvements then by #48728

@dezwei
Copy link
Author

dezwei commented Oct 23, 2019

In which version will the fix be included? 7.5?

@timroes
Copy link
Contributor

timroes commented Oct 25, 2019

@dezwei we're currently still investigating the proper fix for this bug, and I can update here as soon as we know something about fixed versions.

@kertal
Copy link
Member

kertal commented Oct 29, 2019

Fixed by #49326

@antcodd
Copy link

antcodd commented Nov 19, 2019

This bug appears to be mostly fixed in 7.4.2, but there are still some escaping issues. If leaving the label template as blank the URL displayed has escape characters in it. Workaround: explicitly set the label template to {{value}}. The hyperlink is correct.

e.g. https://www.example.com?foo=1&bar=2 displays as https://www.example.com?foo=1&amp;bar=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants