Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactify field formatters #48728

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 21, 2019

Summary

Currently the field formatters produce angular flavored html or plain text. This PR adds an options to format for usage in React. This removed the regression that e.g. links, images, audio formatted content was only displayed as text, and will also be used for our Data Grid implementation.

Fixes #48106

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

@kertal kertal self-assigned this Oct 21, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime
Copy link
Contributor

mattkime commented Jul 9, 2020

@kertal I'm reviewing everything with the FieldFormatter tag - whats the status of this PR?

@kertal
Copy link
Member Author

kertal commented Jul 9, 2020

@kertal this was experimental and should be closed, but of course, having reactified field formatters would be neat :)

@kertal
Copy link
Member Author

kertal commented Jul 13, 2020

Closing this because experimental

@kertal kertal closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Bug in expanded document url-links
3 participants