Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] NP migration core.http.createRouter #49238

Closed
ogupte opened this issue Oct 24, 2019 · 1 comment · Fixed by #49455
Closed

[APM] NP migration core.http.createRouter #49238

ogupte opened this issue Oct 24, 2019 · 1 comment · Fixed by #49455
Assignees
@dgieselaar
Labels
Team:APM All issues that need APM UI Team support v7.6.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Oct 24, 2019 •
edited
Loading

Meta issue: #32894

Migrate from server.route to the NP router core.http.createRouter. Also route handlers which depend on server.savedObjects.SavedObjectsClient can be upgraded to use the SavedObjectsClient from the NP request context (request.getSavedObjectsClient)

See examples of NP router at https://github.com/elastic/kibana/blob/master/src/core/MIGRATION_EXAMPLES.md#3-new-platform-shim-using-new-platform-router.
Ideally we want to use to use option #3 (NP router shim) but we could also inject the legacy router (server.route) into the NP router shim (option #2) if necessary.
@ogupte ogupte added [zube]: Inbox Team:APM All issues that need APM UI Team support v7.6.0 labels Oct 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@jasonrhodes jasonrhodes mentioned this issue Oct 24, 2019
Closed
@dgieselaar dgieselaar self-assigned this Oct 25, 2019
@dgieselaar dgieselaar mentioned this issue Oct 28, 2019
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Nov 21, 2019
@dgieselaar
[APM] Migrate server routes to NP
9b368b4 
Closes elastic#49238.

Pass legacy API to NP plugin in order to use internal SO client

Fix issues with agent configuration APIs

Update tsconfig template for TS optimization

Fix typo
dgieselaar added a commit that referenced this issue Nov 21, 2019
@dgieselaar
[APM] Migrate server routes to NP (#49455)
06bee60 
* [APM] Migrate server routes to NP

Closes #49238.

Pass legacy API to NP plugin in order to use internal SO client

Fix issues with agent configuration APIs

Update tsconfig template for TS optimization

Fix typo

* Review feedback

* Fix type issues after browser duration changes

* Revert changes in getServices due to readability concerns

* Review feedback
dgieselaar added a commit that referenced this issue Nov 25, 2019
@dgieselaar
[APM] Migrate server routes to NP (#49455) (#51289)
1ed1a9f 
* [APM] Migrate server routes to NP

Closes #49238.

Pass legacy API to NP plugin in order to use internal SO client

Fix issues with agent configuration APIs

Update tsconfig template for TS optimization

Fix typo

* Review feedback

* Fix type issues after browser duration changes

* Revert changes in getServices due to readability concerns

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:APM All issues that need APM UI Team support v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Migrate server routes to NP dgieselaar/kibana
4 participants
@sorenlouv @dgieselaar @ogupte @elasticmachine