Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary src/plugins/es_ui_shared eslint overrides #49554

Closed
3 tasks done
spalger opened this issue Oct 28, 2019 · 3 comments · Fixed by #71237
Closed
3 tasks done

Remove temporary src/plugins/es_ui_shared eslint overrides #49554

spalger opened this issue Oct 28, 2019 · 3 comments · Fixed by #71237
Assignees
Labels
chore Meta Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in src/plugins/es_ui_shared. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['src/plugins/es_ui_shared/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jan 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor

@sebelga Should this stay open? I think there are still other parts of ES UI shared that still need to be updated, right?

@sebelga
Copy link
Contributor

sebelga commented Jul 16, 2020

@cjcenizal Yes this should stay open, it automatically closed with the PR merged, which is strange as I only used it in a sentence. ("...one step closer to close (#)49554"). Will need to be even more cautious in the future! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Meta Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants