Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint violations for ES UI form hook lib #73972

Closed
cjcenizal opened this issue Jul 31, 2020 · 1 comment · Fixed by #76392
Closed

Fix eslint violations for ES UI form hook lib #73972

cjcenizal opened this issue Jul 31, 2020 · 1 comment · Fixed by #76392
Assignees
@sebelga
Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

Supports #49554

/kibana/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx
  150:5  error  React Hook useCallback has a missing dependency: 'lastStep'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

kibana/src/plugins/es_ui_shared/static/forms/components/fields/range_field.tsx
  42:5  error  React Hook useCallback has a missing dependency: 'field'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
@cjcenizal cjcenizal added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@spalger spalger mentioned this issue Jul 31, 2020
Closed
3 tasks
@sebelga sebelga mentioned this issue Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebelga sebelga

Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[es_ui_shared] Fix eslint exhaustive deps rule sebelga/kibana
3 participants
@cjcenizal @sebelga @elasticmachine