Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken icons for Metrics/Logs in "Space privileges" #55283

Closed
axw opened this issue Jan 20, 2020 · 1 comment · Fixed by #55292
Closed

Broken icons for Metrics/Logs in "Space privileges" #55283

axw opened this issue Jan 20, 2020 · 1 comment · Fixed by #55292
Assignees
@weltenwort
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@axw
Copy link
Member

axw commented Jan 20, 2020

Kibana version:

7.6.0 BC1

Elasticsearch version:

7.6.0 BC1

Server OS version:

Linux (Docker)

Browser version:

Chrome 79.0.3945.117

Browser OS version:

Ubuntu Linux 18.04

Original install method (e.g. download page, yum, from source, etc.):

Docker

Describe the bug:

  • When adding Space privileges for a role in management/security, icons for "Infrastructure" and "Logs" are broken
  • Infrastructure should probably read "Metrics" instead? CC @jasonrhodes

Steps to reproduce:

  1. Create a stack with security enabled
  2. In Kibana: management > roles > create role
  3. Click "Add space privileges"

Expected behavior:

  • Images shouldn't be broken, and should be the same as in the left-hand nav
  • Privilege names should reflect up-to-date product naming

Screenshots (if relevant):

image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
@axw axw added bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort self-assigned this Jan 20, 2020
@weltenwort weltenwort mentioned this issue Jan 20, 2020
Merged
2 tasks
weltenwort added a commit that referenced this issue Jan 21, 2020
@weltenwort
[Logs UI] Use the correct icons and labels in the feature cont… (#55292)
85edc66 
This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.

fixes #55283
weltenwort added a commit to weltenwort/kibana that referenced this issue Jan 21, 2020
@weltenwort
[Logs UI] Use the correct icons and labels in the feature cont… (elas…
f60ca0d 
…tic#55292)

This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.

fixes elastic#55283
weltenwort added a commit to weltenwort/kibana that referenced this issue Jan 21, 2020
@weltenwort
[Logs UI] Use the correct icons and labels in the feature cont… (elas…
d8ff585 
…tic#55292)

This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.

fixes elastic#55283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Use the correct icons and labels in the feature cont… weltenwort/kibana
4 participants
@sgrodzicki @axw @weltenwort @elasticmachine