Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken "sample data" link within Graph plugin #57205

Closed
mshustov opened this issue Feb 10, 2020 · 8 comments
Closed

Broken "sample data" link within Graph plugin #57205

mshustov opened this issue Feb 10, 2020 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Graph Graph application feature Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

Get Not found error when click on
2020-02-10_14-39-59

@mshustov mshustov added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov added the bug Fixes for quality problems that affect the customer experience label Feb 10, 2020
@nreese
Copy link
Contributor

nreese commented Feb 11, 2020

The path is correct but the application base path is not getting added. Graph is using application.getUrlForApp to build the URL, https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/graph/public/components/guidance_panel/guidance_panel.tsx#L151. Looks like application.getUrlForApp needs to add the base path

@flash1293
Copy link
Contributor

Thanks for checking @nreese . @restrry could you check whether this is a regression of the core API? I didn't dig into it but this change looks like it could have caused it: fdd87e0#diff-1ab7c26e3c5a0d226f771d13620db1e3L141

@flash1293 flash1293 added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

@flash1293 I can confirm this is a regression caused by the given commit. We messed something up when splitting the app url concept between the basePath-free one used for the router/mounter and the basePath-dependant one this API is supposed to return.

@mshustov
Copy link
Contributor Author

created #57301

@mshustov mshustov removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 11, 2020
@pgayvallet
Copy link
Contributor

#57301 has been fixed and backported to 7.6 and 7.x

@nreese can you confirm the issue is resolved?

@nreese
Copy link
Contributor

nreese commented Feb 13, 2020

Confirmed, closed by #57316

@nreese nreese closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Graph Graph application feature Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

5 participants