Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

application.getUrlForApp ignores basePath #57301

Closed
mshustov opened this issue Feb 11, 2020 · 2 comments · Fixed by #57316
Closed

application.getUrlForApp ignores basePath #57301

mshustov opened this issue Feb 11, 2020 · 2 comments · Fixed by #57316
Assignees
@pgayvallet
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.1

Comments

@mshustov
Copy link
Contributor

mshustov commented Feb 11, 2020 •
edited
Loading

changes in application.getUrlForApp
fdd87e0#diff-1ab7c26e3c5a0d226f771d13620db1e3L141
lead to regression: #57205

As a part of bug fix, we could evaluate how much work requires to setup FTR with basePath to test the scenario properly.
@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc regression Feature:New Platform v7.6.1 labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov mentioned this issue Feb 11, 2020
Closed
@pgayvallet pgayvallet mentioned this issue Feb 11, 2020
Merged
2 tasks
@pgayvallet
Copy link
Contributor

Fix is straightforward, adapting the FTR config to use a basePath is not. As this is a regression and should lands in 7.6.1 I created a PR with the simple fix.

@mshustov mshustov mentioned this issue Apr 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preprend basePath in getUrlForApp pgayvallet/kibana
3 participants
@pgayvallet @mshustov @elasticmachine