-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topN splits values incorrectly #641
Comments
This a a function of the elasticsearch terms facet. See #364 |
w33ble
added a commit
to w33ble/kibana
that referenced
this issue
Sep 13, 2018
* chore: move done handler into element handlers and remove the contructor from ElementHandlers * chore: stricter, better defined prop types also add some comments explaining where various handler functions come from * feat: listen for element done calls * feat: dispatch on element done handler also log a warning if the done handler wasn't called within the time limit * fix: image, call done handler once * chore: create ElementShareContainer component move all the done handler and event dispatching stuff into it, and wrap the element renderer * fix: mark elements render as incomplete * fix: move data-render-complete to correct element also track completed state in ElementShareContainer to avoid event race conditions in reporting * chore: switch isProduction to isDevelopment check
w33ble
pushed a commit
to w33ble/kibana
that referenced
this issue
Sep 13, 2018
* Chore: act on todo (raise error if there's more than one child), typos * Refactor: remove a check no longer needed; other minor changes * Feat - horrible and slow and glitchy but works * Fix - removing erratic update due to autofiring keys (a browser behavior workaround) * Chore - remove stale test code * Refactor - move handlers out of class object * Refactor - use recompose withState * Refactor - use a commit callback * Chore - use React event data instead of native event data * Refactor - dealing with event identifiers in aeroelastic * Chore: fix performance and other issues Refactor: separate the page to its own directory Chore: propTypes * Refactor: selected * Refactor: removing former state 1 * Refactor: removing former state 2 * Refactor: removing former state 3 * Refactor: removing former state 4 * Refactor: element_wrapper 2 * Refactor: element_wrapper 3 * Refactor: element_wrapper 4 * Refactor: element_wrapper 5 * Refactor: element_wrapper 6 * Breaking: getting rid of legacy interactable border * Breaking: getting rid of legacy remove circle * Breaking: getting rid of handlers? * Chore: restoring overflow from hidden (cherry picked from commit 69667c2) * Refactor: new transient state to link to React store * Feat: adding new element in react/redux now adds it to the layout * Feat: removing new element in react/redux now removes it from the layout * Chore: avoid unneeded selectElement call * Feat: set position * Feat: adding back the original borders * Refactor: moving the border to its own component * Feat: adding the remove element control * Refactor - still getting stale state * Refactor - no more stale state; selected status moved out of updater * Refactor - do not supply props for the layout state initialization * Refactor - don't persist selection if it was already selected * Refactor - move layout state handling into page/index.js * Refactor - move handlers out via recompose.withHandlers * Chore: linting * Refactor: moved out withLocalState * Refactor: moved out withGlobalState * Refactor: moved out withUpdateStates * Refactor: other minor shuffles * Feat: persist transform changes only when a mouse or keyboard gesture ends * Feat: preparing for mouse rotation (cherry picked from commit 2f8825e) * chore: convert page into workpad_page * chore: use the page id directly * chore: set page isSelected based on global state * Feat: alignment guide lines * Chore: adding missing props after rebase * Chore: simplifications; prep for additional layout * Feat: separated out rotation * chore: remove elements from props they are unused and overwritten anyway * chore: move aeroelastic state sync to middleware easier to watch for actions and react to changes from both states * chore: consolidate the WorkpadPage container * chore: wrap aeroelastic in helper module ensure single state, and internalize some of the selectors * Fix: pass page for saving position change * Feat: layout projected resize markers * Feat: layout projected resize connector lines (blue border by section) * Chore: post-rebase manual updates - less to scss * Chore: post-rebase manual updates - reinstating handlers due to elastic#641 * Fix: solving various interaction and styling issues * Feat: adopting the first round of the new visual design Feat: Z-sorting to show up (required reload) Fix: rotation handle shouldn't allow text selection * Fix: the gotoPage action now also triggers a relayout (contents change) * Fix: don't allow user-select on the workbook page, otherwise texts are selected while dragging (the element texts are not selectable anyway, because attempting to select text of an element will instead drag the element, so doesn't appear to need conditionalization) * Fix: don't show annotations in full screen mode * Fix: don't let mouse events start in full screen mode * Fix: don't deselect elements while holding mousebutton down or dragging * Fix: don't deselect elements when handling resize or rotate hotspots * Fix: attach pointer event handlers to the global object (window) so things can be dragged outside the canvas div, the canvas DOM and even the web browser * Fix: handle the case of deleting an element (delete interaction will eventually go away) * Fix: select element on 1st click on initial load * Chore: post-commit code cleanup * Improv: round transform matrix values (works currently, as exposed functionality doesn't yet include 3D transforms) * Fix: no editing Chore: removed disused props * Chore: no editing code regularization (better name) * Fix: deselection of element works outside the canvas paper too * Chore: reorder some lines for easier comparison to master * Chore: remove obsolete classing * Chore: dedicated delete handler, just for code comparison * Fix: regression introduced with the previous 'click outside of canvas paper' commit * Chore: calc the isSelected property similarly to preexisting master * Fix: page preview to show all slides * Fix: too fast page forward/backward raises an error * Fix: all pages (and layouts) of a workbook are live simultaneously * Chore: removed the commented-out lines that did the slide sorter view * Perf: removed aero middleware hook for gotoPage as now the pages are preloaded, so, faster pagination * Fix: further work on multipage support (switching workpads, adding pages) * Fix: handle the appReady action * Fix: image reveal drag&drop now doesn't attempt to be handled as native D & D * Fix: don't lose the selected status if rotation handle is released away from the handle and the element * Feat: adding deletion by Delete and Backspace keys * Chore: removed disused props * Chore: removed canvas__interactable-meta * Chore: removed the remove hotspot interaction and the element_controls layer * Chore: use the published version of aeroelastic * Refactor: rename lib/aeroelastic to avoid ambiguity * Refactor: move in the `aeroelastic` repo Refactor: remove unneeded part of the repo Refactor: aero flatten file tree Refactor: one more thing to remove Refactor: adopt prettier Refactor: adopt prettier 2; remove debug line Refactor: adopt prettier 3 - matrix ops Refactor: adopt prettier 4 - layout Fix: regression introduced with reduction final mapping Chore: linting 1 Chore: linting 2 Chore: linting 3 Chore: linting 4 Chore: linting 5 Chore: linting 6
This was referenced Apr 7, 2021
This was referenced May 6, 2021
This was referenced Sep 12, 2021
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both topN and derived queries (deprecated) exhibited strange behavior when it comes to determining what a value is. It seems to split values based on certain characters, such as Dashes (-) and At Signs (@), while correctly handling Periods (.). It also downcases all values, which makes camelCased values much harder to read.
The Micro Analysis of a Field (Table Panel) handles these values correctly.
Example
Values
topN/Derived Queries
The text was updated successfully, but these errors were encountered: