Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Remove backend awareness of KQL from alert executor #64832

Closed
Zacqary opened this issue Apr 29, 2020 · 1 comment · Fixed by #64937
Closed

[Metrics UI] Remove backend awareness of KQL from alert executor #64832

Zacqary opened this issue Apr 29, 2020 · 1 comment · Fixed by #64937
Assignees
@Zacqary
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Apr 29, 2020 •
edited by jasonrhodes
Loading

In the getParsedFilterQuery function, remove the handler for a query that cannot be parsed as Elasticsearch JSON.

This was to handle cases of the frontend sending a query in the format of KQL instead of converting it to ES JSON. When #64292 merges this will no longer be a possibility.

The alert should throw an error if it receives invalid JSON instead of trying to parse it as KQL.
@Zacqary Zacqary added Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0 v7.7.1 labels Apr 29, 2020
@Zacqary Zacqary self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

This was referenced Apr 29, 2020
Merged
Merged
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels May 5, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics UI] Require filterQuery to be ES JSON Zacqary/kibana
3 participants
@jasonrhodes @Zacqary @elasticmachine