Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Add inventory metric threshold alerts #64292

Merged
merged 29 commits into from
Apr 30, 2020
Merged

[Metrics UI] Add inventory metric threshold alerts #64292

merged 29 commits into from
Apr 30, 2020

Conversation

phillipb
Copy link
Contributor

@phillipb phillipb commented Apr 23, 2020 •
edited
Loading

Summary

Add the ability to create alerts from the inventory screen. Fixes: #63996.

Screen Shot 2020-04-23 at 7 01 01 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

phillipb added 13 commits April 23, 2020 05:44
@phillipb
Add new inventory metric threshold alert
9c07f66
@phillipb
Add missed file
e9862d1
@phillipb
Merge branch 'master' of https://github.com/elastic/kibana into add-i…
1075656 
…nventory-metric-threshold-alerts
@phillipb
Fix some types
70b5513
@phillipb
Convert units on client and executor.
5e033ff
@phillipb
Move formatters to common. Properly format metrics in alert messages
b0818d7
@phillipb
Merge branch 'master' of https://github.com/elastic/kibana into add-i…
bb77f2e 
…nventory-metric-threshold-alerts
@phillipb
Merge branch 'master' of https://github.com/elastic/kibana into add-i…
e4a35c6 
…nventory-metric-threshold-alerts
@phillipb
Style changes
591e822
@phillipb
Remove unused files
8a009bc
@phillipb
Merge branch 'master' of https://github.com/elastic/kibana into add-i…
f81a46a 
…nventory-metric-threshold-alerts
@phillipb
fix test
4416d70
@phillipb
Update create
3de0333
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@phillipb phillipb marked this pull request as ready for review April 28, 2020 13:59
@phillipb phillipb requested a review from a team as a code owner April 28, 2020 13:59
@phillipb phillipb added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0 v8.0.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

simianhacker
simianhacker requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an error in the executor, the filterQuery doesn't seem to be getting parsed correctly:

[error][alerting][alerting][plugins][plugins] Executing Alert "43a996e6-3cde-4118-bbef-4e768860270f" has resulted in Error: Failed to parse query: SyntaxError: Unexpected token h in JSON at position 0

Also the filter bar is missing in the alert management. We should probably impliment the same fixes from #64597

alert in management

image

alert in inventory view

image

x-pack/plugins/infra/common/formatters/bytes.test.ts Outdated Show resolved Hide resolved
x-pack/plugins/infra/common/formatters/index.ts Outdated Show resolved Hide resolved
...er/lib/alerting/inventory_metric_threshold/register_inventory_metric_threshold_alert_type.ts Show resolved Hide resolved
@phillipb phillipb changed the title Add inventory metric threshold alerts [Metrics UI] Add inventory metric threshold alerts Apr 29, 2020
@Zacqary Zacqary mentioned this pull request Apr 29, 2020
Merged
@Zacqary Zacqary mentioned this pull request Apr 29, 2020
Closed
simianhacker
simianhacker approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I create an alert from both the inventory view and the central management view. I edited an alert from the central management as well. Everything appears to be working.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit 3cef8e6 into elastic:master Apr 30, 2020
v1v added a commit to v1v/kibana that referenced this pull request May 4, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
0dd3b32 
* upstream/master: (315 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
68c12f9 
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (51 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/common/types.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'master' into alerting/np-tests-migration
7215df9 
* master: (44 commits)
  onEvent prop for expression component (elastic#64995)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  ...
This was referenced May 4, 2020
Closed
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64292 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2020
Zacqary pushed a commit to Zacqary/kibana that referenced this pull request May 5, 2020
@phillipb @elasticmachine @Zacqary
[Metrics UI] Add inventory metric threshold alerts (elastic#64292)
e3b9131 
* Add new inventory metric threshold alert

* Add missed file

* Fix some types

* Convert units on client and executor.

* Move formatters to common. Properly format metrics in alert messages

* Style changes

* Remove unused files

* fix test

* Update create

* Fix signature

* Remove old test. Remove unecessary import

* Pass in filter when clicking create alert from context menu

* Fix filtering

* Fix more types

* Fix tests

* Fix merge

* Fix merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Zacqary Zacqary mentioned this pull request May 5, 2020
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 5, 2020
Zacqary added a commit that referenced this pull request May 5, 2020
@Zacqary
[7.x] [Metrics UI] Add inventory metric threshold alerts (#64292) (#6…
d6b19b7 
…5287)
spalger pushed a commit that referenced this pull request May 5, 2020
Revert "[7.x] [Metrics UI] Add inventory metric threshold alerts (#64292
305a821 
) (#65287)"

This reverts commit d6b19b7.
spalger pushed a commit that referenced this pull request May 5, 2020
Revert "[7.x] [Metrics UI] Add inventory metric threshold alerts (#64292
ab97f2f 
)" (#65391)
spalger pushed a commit that referenced this pull request May 5, 2020
Revert "Revert "[7.x] [Metrics UI] Add inventory metric threshold ale…
28ac704 
…rts (#64292)" (#65391)"

This reverts commit ab97f2f.
spalger pushed a commit to spalger/kibana that referenced this pull request May 5, 2020
@phillipb @elasticmachine @spalger
[Metrics UI] Add inventory metric threshold alerts (elastic#64292)
e5aaa39 
* Add new inventory metric threshold alert

* Add missed file

* Fix some types

* Convert units on client and executor.

* Move formatters to common. Properly format metrics in alert messages

* Style changes

* Remove unused files

* fix test

* Update create

* Fix signature

* Remove old test. Remove unecessary import

* Pass in filter when clicking create alert from context menu

* Fix filtering

* Fix more types

* Fix tests

* Fix merge

* Fix merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger mentioned this pull request May 5, 2020
Merged
spalger pushed a commit that referenced this pull request May 6, 2020
@phillipb @elasticmachine
[7.x] [Metrics UI] Add inventory metric threshold alerts (#64292) (#6…
9ee2574 
…5392)

* [Metrics UI] Add inventory metric threshold alerts (#64292)

* Add new inventory metric threshold alert

* Add missed file

* Fix some types

* Convert units on client and executor.

* Move formatters to common. Properly format metrics in alert messages

* Style changes

* Remove unused files

* fix test

* Update create

* Fix signature

* Remove old test. Remove unecessary import

* Pass in filter when clicking create alert from context menu

* Fix filtering

* Fix more types

* Fix tests

* Fix merge

* Fix merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Add missing capabilities

Co-authored-by: Phillip Burch <phillip.burch@live.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Add alerts to the inventory screen
4 participants
@phillipb @elasticmachine @kibanamachine @simianhacker