Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] NP Migration complete client cutover #62908

Merged
merged 29 commits into from
Apr 30, 2020
Merged

[Monitoring] NP Migration complete client cutover #62908

merged 29 commits into from
Apr 30, 2020

Conversation

igoristic
Copy link
Contributor

@igoristic igoristic commented Apr 8, 2020 •
edited
Loading

This is the complete NP cutover phase for the Stack Monitoring client

  • Fix all jest/linting tests
  • Removed all unused legacy files
  • Move all files outside the legacy directory

@igoristic igoristic added Team:Monitoring Stack Monitoring team v8.0.0 labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

This was referenced Apr 14, 2020
Merged
Closed
@jasonrhodes
Copy link
Member

@igoristic what's still left with this PR? Anything you need help with?

@igoristic
Copy link
Contributor Author

What's still left with this PR? Anything you need help with?

@jasonrhodes Not much left, just need to merge the rest of my branches and fix some conflicts with master.

I think I'm good (for now), this shouldn't take long, but will definitely reach out if I get stuck. Thanks for the offer 🙇

@igoristic igoristic requested review from a team, chrisronline and joshdover April 22, 2020 09:27
@igoristic igoristic marked this pull request as ready for review April 22, 2020 09:28
@igoristic igoristic requested a review from a team as a code owner April 22, 2020 09:28
@igoristic igoristic added release_note:skip Skip the PR/issue when compiling release notes v7.7.1 labels Apr 22, 2020
@cchaos cchaos requested a review from andreadelrio April 22, 2020 13:59
@igoristic igoristic requested a review from joshdover April 27, 2020 23:05
@joshdover joshdover mentioned this pull request Apr 30, 2020
Merged
joshdover
joshdover approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level review and manual testing LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

snide
snide approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like moves mostly. LGTM on the sass side. Small comment for a later PR.

x-pack/plugins/monitoring/public/angular/app_modules.ts
// required for `ngSanitize` angular module
import 'angular-sanitize';
import 'angular-route';
import '../index.scss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider breaking this up (in a later PR). You can now import the individual sass files directly into the component themselves import './my_component.scss. Otherwise the entirety of the the css loads at once. Just helps with performance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, Thank you!

@igoristic igoristic merged commit 59315bc into elastic:master Apr 30, 2020
@igoristic igoristic deleted the np_ready_final branch April 30, 2020 19:59
@sorenlouv sorenlouv mentioned this pull request May 1, 2020
Closed
sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request May 1, 2020
@igoristic @sorenlouv
[Monitoring] NP Migration complete client cutover (elastic#62908)
05ebc59 
* Final phase before the complete cutover

* NP migration

* lint fix

* More NP stuff

* Moved Stack Monitoring client plugin outside legacy and fixed all tests

* ...

* Removed unused files

* Fix for main links

* Fixed more tests

* Fixed redirect when clicking on SM icon again

* Code review feedback

* Addressed code review feedback

* Fixed return value
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/legacy/plugins/monitoring/public/components/license/index.js
#	x-pack/plugins/monitoring/public/components/beats/listing/listing.js
v1v added a commit to v1v/kibana that referenced this pull request May 4, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
0dd3b32 
* upstream/master: (315 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
68c12f9 
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (51 commits)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  Ingest Node Pipelines UI (elastic#62321)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/common/types.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'master' into alerting/np-tests-migration
7215df9 
* master: (44 commits)
  onEvent prop for expression component (elastic#64995)
  [APM] Fix failing `ApmIndices` test (elastic#64965)
  [APM] Fix paths for ts optimization script (elastic#65012)
  Use HDR for percentiles (elastic#64758)
  [EPM] fix updates available filter (elastic#64957)
  [Uptime] Certificates page (elastic#64059)
  load lens app lazily (elastic#64769)
  [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954)
  Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742)
  [data.search.aggs] Remove legacy aggs APIs. (elastic#64719)
  Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927)
  [Discover] Show doc viewer action buttons on focus (elastic#64912)
  [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932)
  [Metrics UI] Add inventory metric threshold alerts (elastic#64292)
  [Canvas] Adds edit menu (elastic#64738)
  [Canvas] Adds refresh and autoplay options to view menu (elastic#64375)
  [Lens] Trigger a filter action on click in datatable visualization (elastic#63840)
  [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450)
  [APM] Client new platform migration (elastic#64046)
  [Monitoring] NP Migration complete client cutover (elastic#62908)
  ...
@igoristic igoristic mentioned this pull request May 4, 2020
Closed
igoristic added a commit to igoristic/kibana that referenced this pull request May 4, 2020
@igoristic
[Monitoring] NP Migration complete client cutover (elastic#62908)
a21079e 
* Final phase before the complete cutover

* NP migration

* lint fix

* More NP stuff

* Moved Stack Monitoring client plugin outside legacy and fixed all tests

* ...

* Removed unused files

* Fix for main links

* Fixed more tests

* Fixed redirect when clicking on SM icon again

* Code review feedback

* Addressed code review feedback

* Fixed return value
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/legacy/plugins/monitoring/public/components/license/index.js
#	x-pack/plugins/monitoring/public/components/beats/listing/listing.js
@igoristic igoristic added v7.8.0 and removed v7.7.1 labels May 4, 2020
@igoristic igoristic mentioned this pull request May 4, 2020
Merged
igoristic added a commit to igoristic/kibana that referenced this pull request May 4, 2020
@igoristic
[Monitoring] NP Migration complete client cutover (elastic#62908)
3e43f6a 
* Final phase before the complete cutover

* NP migration

* lint fix

* More NP stuff

* Moved Stack Monitoring client plugin outside legacy and fixed all tests

* ...

* Removed unused files

* Fix for main links

* Fixed more tests

* Fixed redirect when clicking on SM icon again

* Code review feedback

* Addressed code review feedback

* Fixed return value
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/legacy/plugins/monitoring/public/components/license/index.js
#	x-pack/plugins/monitoring/public/components/beats/listing/listing.js
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 5, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

igoristic added a commit that referenced this pull request May 5, 2020
@igoristic @elasticmachine
[7.x] [Monitoring] NP Migration complete client cutover (#62908) (#65144
12b3c36 
)

* [Monitoring] NP Migration complete client cutover (#62908)

* Final phase before the complete cutover

* NP migration

* lint fix

* More NP stuff

* Moved Stack Monitoring client plugin outside legacy and fixed all tests

* ...

* Removed unused files

* Fix for main links

* Fixed more tests

* Fixed redirect when clicking on SM icon again

* Code review feedback

* Addressed code review feedback

* Fixed return value
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/legacy/plugins/monitoring/public/components/license/index.js
#	x-pack/plugins/monitoring/public/components/beats/listing/listing.js

* Fixed conflicts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 5, 2020
@igoristic
Copy link
Contributor Author

Backport:
7.x: 1ec28fd

@chrisronline chrisronline mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator left review comments

@legrego legrego legrego approved these changes

@joshdover joshdover joshdover approved these changes

@spalger spalger spalger approved these changes

@snide snide snide approved these changes

@chrisronline chrisronline chrisronline approved these changes

@andreadelrio andreadelrio Awaiting requested review from andreadelrio

Assignees
No one assigned
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@igoristic @elasticmachine @jasonrhodes @joshdover @kibanamachine @ycombinator @chrisronline @snide @spalger @legrego