-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow browsers to cache static assets #6520
Comments
+1 |
+1 definitely. I was having fits trying to figure out what was going on. Hopefully this will be addressed as I'm going to have large numbers of users, and really don't want to require them all to constantly download the same files when they could be cached. |
By default Hapi sends cache-control: no-cache headers. Because we version our static assets anyway, setting a nice long max-age on these responses is a huge and easy performance win. I've set max-age to an arbitrary, large period of one year.
Please fix this. The |
Any update on the cache control? I am working on kibana 5.6 and on being Iframed the dashboard, I am getting the response header as "cache-control:no-cache". |
same as @vijaygoturi for me |
This seems like super low fruit to me, and the impact would be significant. It does require some testing around upgrading kibana and installing/removing plugins, but if we made it possible to disable http caching via a kibana.yml configuration, the risk here is pretty low even if we do hit edge cases with the caching. |
+1... this is huge for our customers as the initial experience is horrible. Waiting 1-5 seconds for an app to load isn't acceptable. It seems broken to many people. |
Hi I am confused why it still does not cache anything in kibana 7.9.0 ... For example, every time the url Response headers:
I am using Chrome 86. |
Hi after more than a month... It still does not cache. Could anyone provide some suggestions? Thanks! |
eui@72.2.0 ⏩ eui@73.0.0 --- **Bug fixes** - Fixed `EuiDataGrid` a11y errors within toolbar popovers containing draggable elements with interactive children ([#6517](elastic/eui#6517)) - Fixed several styling bugs within `EuiDataGrid`'s sorting toolbar popover ([#6517](elastic/eui#6517)) **Breaking changes** - `EuiToolTip`s now internally enforce only showing **one** tooltip at a time (the most recently triggered tooltip). This primarily affects scenarios where users are focused on a tooltip toggle via click, and then hover onto another tooltip toggle. ([#6520](elastic/eui#6520))
Was this fixed? |
I am still getting this issue on kibana 7.6.0 |
Right now we send
cache-control: no-cache
in response to requests for the webpack generated css and js bundles, and probably other static assets. Since these files only change as often as the Kibana version, and we already send the build number as a query param in the request to bust the cache, we should totally allow the browser to cache them. But Kibana is a single page app you say, it's only the initial page load that's slow so it's not that important. But that's not always the case.The text was updated successfully, but these errors were encountered: