Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow browsers to cache static assets #6520

Closed
Bargs opened this issue Mar 11, 2016 · 11 comments
Closed

Allow browsers to cache static assets #6520

Bargs opened this issue Mar 11, 2016 · 11 comments
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bargs
Copy link
Contributor

Bargs commented Mar 11, 2016

Right now we send cache-control: no-cache in response to requests for the webpack generated css and js bundles, and probably other static assets. Since these files only change as often as the Kibana version, and we already send the build number as a query param in the request to bust the cache, we should totally allow the browser to cache them. But Kibana is a single page app you say, it's only the initial page load that's slow so it's not that important. But that's not always the case.

@Bargs Bargs added the P3 label Mar 11, 2016
@cpitzak
Copy link

cpitzak commented Mar 21, 2016

+1

@grindthemall
Copy link

+1 definitely.

I was having fits trying to figure out what was going on. Hopefully this will be addressed as I'm going to have large numbers of users, and really don't want to require them all to constantly download the same files when they could be cached.

Bargs added a commit to Bargs/kibana that referenced this issue Jul 2, 2016
By default Hapi sends cache-control: no-cache headers. Because we
version our static assets anyway, setting a nice long max-age on these
responses is a huge and easy performance win. I've set max-age to an
arbitrary, large period of one year.
@ChrisCinelli
Copy link

ChrisCinelli commented Jan 26, 2017

Please fix this. The index.jsis currently 5Mb... when I am on the go it takes forever to load it!

@epixa epixa removed the P3 label Apr 25, 2017
@vijaygoturi
Copy link

vijaygoturi commented Nov 7, 2017

Any update on the cache control? I am working on kibana 5.6 and on being Iframed the dashboard, I am getting the response header as "cache-control:no-cache".

@BlueBeN82
Copy link

same as @vijaygoturi for me

@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 4, 2018
@epixa
Copy link
Contributor

epixa commented Jan 4, 2018

This seems like super low fruit to me, and the impact would be significant. It does require some testing around upgrading kibana and installing/removing plugins, but if we made it possible to disable http caching via a kibana.yml configuration, the risk here is pretty low even if we do hit edge cases with the caching.

@epixa epixa added the good first issue low hanging fruit label Jan 4, 2018
@burtonator
Copy link

+1... this is huge for our customers as the initial experience is horrible. Waiting 1-5 seconds for an app to load isn't acceptable. It seems broken to many people.

@fzyzcjy
Copy link

fzyzcjy commented Oct 29, 2020

Hi I am confused why it still does not cache anything in kibana 7.9.0 ...

For example, every time the url https://localhost:5601/33813/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js is fetched and about 1MB of js is downloaded which is unacceptable. (There are also many other large files, such as https://localhost:5601/33813/bundles/plugin/ml/ml.plugin.js and so on.)

Response headers:

cache-control: max-age=31536000
Connection: keep-alive
content-encoding: br
content-type: application/javascript; charset=utf-8
Date: Thu, 29 Oct 2020 13:31:45 GMT
kbn-license-sig: ...
kbn-name: elastic
kbn-xpack-sig: ...
Transfer-Encoding: chunked
vary: accept-encoding

I am using Chrome 86.

@fzyzcjy
Copy link

fzyzcjy commented Dec 25, 2020

Hi after more than a month... It still does not cache. Could anyone provide some suggestions? Thanks!

breehall added a commit that referenced this issue Jan 19, 2023
eui@72.2.0 ⏩ eui@73.0.0

---

**Bug fixes**

- Fixed `EuiDataGrid` a11y errors within toolbar popovers containing
draggable elements with interactive children
([#6517](elastic/eui#6517))
- Fixed several styling bugs within `EuiDataGrid`'s sorting toolbar
popover ([#6517](elastic/eui#6517))

**Breaking changes**

- `EuiToolTip`s now internally enforce only showing **one** tooltip at a
time (the most recently triggered tooltip). This primarily affects
scenarios where users are focused on a tooltip toggle via click, and
then hover onto another tooltip toggle.
([#6520](elastic/eui#6520))
@abhisheksoni27
Copy link

Was this fixed?

@abhisheksoni27
Copy link

I am still getting this issue on kibana 7.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

10 participants