Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There seems to be a wrong assignment in kibana/public/settings/index.js #6588

Closed
szydan opened this issue Mar 21, 2016 · 1 comment
Closed

There seems to be a wrong assignment in kibana/public/settings/index.js #6588

szydan opened this issue Mar 21, 2016 · 1 comment
Labels
chore good first issue low hanging fruit

Comments

@szydan
Copy link
Contributor

szydan commented Mar 21, 2016

It looks like one of the lines was left there by mistake ?

$scope.sections = sections;
$scope.sections = sections.inOrder;

kibana/src/plugins/kibana/public/settings/index.js

Line 43 in 6c9c9b9

$scope.sections = sections.inOrder;

@spalger spalger assigned spalger and unassigned spalger Mar 21, 2016
@bevacqua bevacqua self-assigned this Mar 30, 2016
@bevacqua
Copy link
Contributor

Good catch. Thanks for reporting.

bevacqua added a commit that referenced this issue Mar 31, 2016
@bevacqua
Merge pull request #6709 from bevacqua/chore/settings-codestyle
26cedc7 
[chore] Cleanup settings code style as reported by #6588.
@bevacqua bevacqua removed their assignment Mar 31, 2016
elastic-jasper added a commit that referenced this issue Mar 31, 2016
@elastic-jasper
Backport PR #6709
f456be9 
---------

**Commit 1:**
[chore] Cleanup settings code style as reported. Fixes #6588.

* Original sha: 7b43d52
* Authored by Nicolas Bevacqua <nicolasbevacqua@gmail.com> on 2016-03-30T20:11:35Z
elastic-jasper added a commit that referenced this issue Mar 31, 2016
@elastic-jasper
Backport PR #6709
a13ab16 
---------

**Commit 1:**
[chore] Cleanup settings code style as reported. Fixes #6588.

* Original sha: 7b43d52
* Authored by Nicolas Bevacqua <nicolasbevacqua@gmail.com> on 2016-03-30T20:11:35Z
This was referenced Mar 31, 2016
Closed
Closed
cee-chen added a commit that referenced this issue Feb 15, 2023
@cee-chen
Upgrade EUI to v75.1.0 (#151200)
af25a3e 
## Summary

`eui@75.0.0` ⏩ `eui@75.1.0`

---

## [`75.1.0`](https://github.com/elastic/eui/tree/v75.1.0)

- Added padding to `EuiStep` title to better align with icon
([#6555](elastic/eui#6555))
- Added a new `lineNumbers.annotations` API to `EuiCodeBlock`. This new
feature displays an informational icon next to the specified line
number(s), providing more context via popover
([#6580](elastic/eui#6580))

**Bug fixes**

- Fixed bug in `EuiRange` where styles were applied incorrectly when
custom ticks were passed but `showTicks` were false
([#6588](elastic/eui#6588))
- Fixed `fleetApp` and `agentApp` icons that were swapped
([#6590](elastic/eui#6590))

**CSS-in-JS conversions**

- Converted `EuiSteps` to Emotion; Removed `$euiStepStatusColorsToFade`,
`$euiStepNumberSize`, `$euiStepNumberSmallSize`, and
`$euiStepNumberMargin`
([#6555](elastic/eui#6555))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szydan @bevacqua @spalger