Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom metric label in pie chart mouseovers #6605

Closed
tbragin opened this issue Mar 22, 2016 · 11 comments · Fixed by #10219
Closed

Use custom metric label in pie chart mouseovers #6605

tbragin opened this issue Mar 22, 2016 · 11 comments · Fixed by #10219
Assignees
@ppisljar
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent

Comments

@tbragin
Copy link
Contributor

tbragin commented Mar 22, 2016

Looks like the new custom metric label is not respected in pie chart mouseovers.
screen shot 2016-03-22 at 4 08 22 pm

It is respected in bar chart mouse overs, for comparison
screen shot 2016-03-22 at 4 09 17 pm
@tbragin tbragin added bug Fixes for quality problems that affect the customer experience v4.5.1 labels Mar 22, 2016
@epixa epixa removed the v4.5.1 label May 14, 2016
@PhaedrusTheGreek
Copy link
Contributor

+1 for the fix

@JeremyColton
Copy link

JeremyColton commented Jul 4, 2016 •
edited
Loading

Any timeline on when this fix is being released?
Many thanks.

@sethyes
Copy link

sethyes commented Jul 19, 2016

Additionally, this does not work for split pie charts in one visualization. However it does work for split bar charts.

I've done some initial investigation into the visState json but the problem appears deeper than that.

@Nilamkhule
Copy link

+1 for fix

@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 1, 2016
@tbragin tbragin mentioned this issue Nov 20, 2016
Closed
@tbragin tbragin added the P2 label Nov 20, 2016
@thekofimensah
Copy link

+1

3 similar comments
@derekluo
Copy link

+1

@hariwalters
Copy link

+1

@babadofar
Copy link

+1

@bhavyarm
Copy link
Contributor

@tbragin happening in 5.x too(found it in 5.2.0 pre-release QA).

@lukasolson lukasolson mentioned this issue Jan 19, 2017
Closed
@ppisljar ppisljar self-assigned this Feb 7, 2017
@ppisljar ppisljar mentioned this issue Feb 7, 2017
Merged
@jsarmento
Copy link

+1

@ppisljar
Copy link
Member

ppisljar commented Feb 9, 2017

PR is up and being reviewed ... hopefully it goes in into next minor version

jbudz added a commit that referenced this issue Mar 14, 2023
@JasonStoltz @daveyholler
@cee-chen @kibanamachine @jbudz
Upgraded EUI to v76.0.0 (#152506)
c339ca8 
👋 Hi all - the biggest breaking change of this PR is around two icon
type changes/renames.

1. ⚠️ **The  `alert` icon is now named `warning`**
- <img width="103" alt=""
src="https://user-images.githubusercontent.com/549407/223561599-8913e88c-676f-47cd-aaed-81b64783bd81.png"
align="middle">
- This change should have been automatically converted on your behalf by
the EUI team, **but if for some reason** we missed making this
conversion in this PR and your icon(s) are now broken, please ping us or
let us know in this PR (or fix yourself after this PR merges).
- In some cases, teams were using this icon for error messages,
alongside the `danger` color. In those cases, we opinionatedly changed
those icon usages to the new `error` icon instead of using the old
alert/warning icon.

2. 🛑 **The `crossInACircleFilled` icon has been removed, and a new
`error` icon added**
- <img width="84" alt=""
src="https://user-images.githubusercontent.com/549407/223561892-4406bdf6-1a55-49ac-85ad-3a11eb7c090d.png"
align="middle">
- The conversion for this breaking change was not straightforward. This
was the path we used to determine what to change `crossInACircleFilled`
usages to:
- If the icon was associated with errors or error messages, we changed
it to the new `error` icon.
- If a "delete" action was associated with this icon, we changed it to
the `trash` icon instead.
- If a "clear" action was associated with this icon, we changed it to
just the `cross` icon, or in some cases `minusInCircleFilled` (if used
alongside `plusInCircleFilled`).
- Again, if we made a mistake during this conversion or missed your
plugin, please feel free to ping us.

## Summary

`eui@75.1.2` ⏩ `eui@76.0.2`

## [`76.0.2`](https://github.com/elastic/eui/tree/v76.0.2)

**Bug fixes**

- Added a legacy `alert` alias for the `warning` `EuiIcon` type
([#6640](elastic/eui#6640))

## [`76.0.1`](https://github.com/elastic/eui/tree/v76.0.1)

**Bug fixes**

- Fixed broken icons on all `isInvalid` form controls
([#6629](elastic/eui#6629))

## [`76.0.0`](https://github.com/elastic/eui/tree/v76.0.0)

- Added `pivot` glyph to `EuiIcon`
([#6605](elastic/eui#6605))
- Added the `displayHeaderCellProps` API to `EuiDataGrid`'s columns,
which allows passing custom props directly to column header cells
([#6609](elastic/eui#6609))
- Added the new `headerCellProps`/`footerCellProps` APIs to
`EuiDataGrid`'s control columns, which allows passing custom props
directly to control column header or footer cells
([#6609](elastic/eui#6609))
- Added a new `footerCellRender` API to `EuiDataGrid`'s control columns,
which allows completely customizing control column rendering (previously
rendered an empty cell)
([#6609](elastic/eui#6609))
- Updated the styling of nested ordered lists in `EuiText` to align with
GitHub's list style, which is a popular format used in Markdown or MDX
formatting ([#6615](elastic/eui#6615))
- Added a margin-bottom property exclusively to the direct child `ul`
and `ol` elements of the `EuiText` component
([#6615](elastic/eui#6615))
- Fix issue with badges appearing within an `EuiBadgeGroup`, where the
CSS rule to override the `margin-inline-start` was not being applied
correctly due to the order of appearance in the CSS rules
([#6618](elastic/eui#6618))

**Bug fixes**

- Fixed `EuiDataGrid` footer control columns rendering with cell
expansion popovers when they should not have been
([#6609](elastic/eui#6609))
- Fixed an `EuiSkipLink` bug where main content loading in
progressively/dynamically after the skip link rendered was not being
correctly focused ([#6613](elastic/eui#6613))

**Breaking changes**

- Renamed `EuiIcon`'s `alert` to `warning`
([#6608](elastic/eui#6608))
- Removed `EuiIcon`'s `crossInACircleFilled` in favor of `error`
([#6608](elastic/eui#6608))

---------

Co-authored-by: Davey Holler <daveyholler@hey.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing pie chart tooltip custom label bug ppisljar/kibana