[Maps] Fit to Data is not working with EMS Boundaries

[jsanz]

Kibana version:
master

Elasticsearch version:
master

Server OS version:
ubuntu 19.10

Browser version:
Chromium: 81.0.4044.138 (Official Build) (64-bit)

Browser OS version:
ubuntu 19.10

Original install method (e.g. download page, yum, from source, etc.):
sources

Describe the bug:

The Fit to data feature in Maps is not working for layers based on EMS Boundaries

Steps to reproduce:

1. Create a map
2. Add an EMS Boundaries layer (say Andorra)
3. Click on the tooltip Fit to data or the global Fit to data bounds button
4. The map stays at worldwide bounds

Expected behavior:
Map zooms to the country boundaries.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[jsanz]

Issue detected when testing #66452

[thomasneirynck]

oddly enough, this does work but only when the EMS-layer has term-joins.

[nreese]

The problem is in https://github.com/elastic/kibana/blob/master/x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.js#L162. FEATURE_VISIBLE_PROPERTY_NAME is only set when joins are applied. I can create a fix

_getBoundsBasedOnData() {
    const featureCollection = this._getSourceFeatureCollection();
    if (!featureCollection) {
      return null;
    }

    const visibleFeatures = featureCollection.features.filter(
      feature => feature.properties[FEATURE_VISIBLE_PROPERTY_NAME]
    );
    const bbox = turf.bbox({
      type: 'FeatureCollection',
      features: visibleFeatures,
    });
    return {
      minLon: bbox[0],
      minLat: bbox[1],
      maxLon: bbox[2],
      maxLat: bbox[3],
    };
  }