Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Map] return bounding box for static feature collection without joins #66607

Merged
merged 3 commits into from
May 15, 2020
Merged

[Map] return bounding box for static feature collection without joins #66607

merged 3 commits into from
May 15, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 14, 2020

fixes #66582

@nreese nreese requested a review from a team as a code owner May 14, 2020 18:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

thomasneirynck
thomasneirynck reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix and the small refactor to add the test.

There's an edge-case that still breaks:

Layers with term-joins that are not backed by EMS, but by ES-doc layers.

e.g.

  • download world-countries from https://maps.elastic.co/#file/world_countries
  • upload with GeoJson uploader in Maps
  • add layer: turn apply-global-filter switch off
  • add term-join with sample-logs on iso2=geo.dest
    => fit2bounds will always navigate to entire layer iso only to the countries that have a matching join

I think the fix would be that if a layer has joins, it always should check against the visibility of features in the source-feature-collection and not delegate to Source#getBoundsForFilters. Am I missing something?

This check:
https://github.com/nreese/kibana/blob/bf178dece9b0f70f33d1bd3c89eb972318d7ecfb/x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.js#L178

should be refined then to also check if the layer has joins.

Thoughts on adding it to this PR (?)

thomasneirynck
thomasneirynck approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with @nreese

will use new PR for edge-case when layer is an ES-doc layer

@thomasneirynck thomasneirynck mentioned this pull request May 14, 2020
Closed
@nreese
Copy link
Contributor Author

nreese commented May 14, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit f33b6b6 into elastic:master May 15, 2020
nreese added a commit to nreese/kibana that referenced this pull request May 15, 2020
@nreese @elasticmachine
[Map] return bounding box for static feature collection without joins (…
0153e16 
…elastic#66607)

* [Map] return bounding box for static feature collection without joins

* tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese mentioned this pull request May 15, 2020
Merged
nreese added a commit to nreese/kibana that referenced this pull request May 15, 2020
@nreese
[Map] return bounding box for static feature collection without joins (…
ca5361f 
…elastic#66607)

* [Map] return bounding box for static feature collection without joins

* tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.js
This was referenced May 15, 2020
Closed
Merged
nreese added a commit that referenced this pull request May 15, 2020
@nreese @elasticmachine
[Map] return bounding box for static feature collection without joins (…
02290b2 
…#66607) (#66724)

* [Map] return bounding box for static feature collection without joins

* tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 15, 2020
@gmmorris
Merge branch 'master' into saved-objects/scoped-client-with-extra-types
d5bddce 
* master: (191 commits)
  [Maps] Get number of categories from palette (elastic#66454)
  move oss features registration to KP (elastic#66524)
  [kbn/plugin-helpers] typescript-ify (elastic#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746)
  FTR: move basic services under common folder (elastic#66563)
  Migrate Beats Management UI to KP (elastic#65791)
  [CI] Add 20 minutes to overall build timeout
  lint import from restricted zones for export exressions (elastic#66588)
  [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332)
  KP plugins shouldn't need package.json (elastic#66654)
  Replace agent metrics link with the new one (elastic#66632)
  [CI] Add one retry to setup step (elastic#66638)
  [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580)
  [docLinks] Add docLinks to CoreSetup. (elastic#66631)
  [DOCS] Rename monitoring collection from internal to legacy (elastic#65781)
  unskip newsfeed tests (elastic#66562)
  [NP] Migrate uiSettings owned by Kibana app (elastic#64321)
  [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706)
  [Map] return bounding box for static feature collection without joins (elastic#66607)
  remove trailing slash in graph sample data links (elastic#66358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Fit to Data is not working with EMS Boundaries
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck