Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Race condition leading to elision of overview page monitors #67842

Closed
andrewvc opened this issue Jun 1, 2020 · 1 comment · Fixed by #67843
Closed

[Uptime] Race condition leading to elision of overview page monitors #67842

andrewvc opened this issue Jun 1, 2020 · 1 comment · Fixed by #67843
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jun 1, 2020

Overview page list omits some matching monitors due to a race condition where:

  1. In the potential matches phase we match a monitor ID / group
  2. After that point a new document for that monitor is indexed
  3. During the refine phase we detect a mismatch between the most recent group ID and the matched one.

This only appears in this sequence, which is more prevalent when the connection between kibana and the ES server is relatively slow. Cloud does this, local dev does not.
@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

andrewvc added a commit to andrewvc/kibana that referenced this issue Jun 1, 2020
@andrewvc
[Uptime] Fix race on overview page query
2acbb20 
Fixes elastic#67842 by requerying
during the refine phase to see if a newer matching doc has come in.
@andrewvc andrewvc mentioned this issue Jun 1, 2020
Merged
1 task
andrewvc added a commit that referenced this issue Jun 9, 2020
@andrewvc
[Uptime] Fix race on overview page query (#67843)
ccb6073 
Fixes #67842 by requerying
during the refine phase to see if a newer matching doc has come in.
andrewvc added a commit to andrewvc/kibana that referenced this issue Jun 9, 2020
@andrewvc
[Uptime] Fix race on overview page query (elastic#67843)
b7b8d05 
Fixes elastic#67842 by requerying
during the refine phase to see if a newer matching doc has come in.
andrewvc added a commit to andrewvc/kibana that referenced this issue Jun 9, 2020
@andrewvc
[Uptime] Fix race on overview page query (elastic#67843)
d816166 
Fixes elastic#67842 by requerying
during the refine phase to see if a newer matching doc has come in.
andrewvc added a commit that referenced this issue Jun 10, 2020
@andrewvc
[Uptime] Fix race on overview page query (#67843) (#68702)
346b61b 
Fixes #67842 by requerying
during the refine phase to see if a newer matching doc has come in.
andrewvc added a commit that referenced this issue Jun 10, 2020
@andrewvc
[Uptime] Fix race on overview page query (#67843) (#68701)
47567c3 
Fixes #67842 by requerying
during the refine phase to see if a newer matching doc has come in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Fix race on overview page query andrewvc/kibana
2 participants
@andrewvc @elasticmachine