-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Improve sidebar design #68206
Comments
Pinging @elastic/kibana-design (Team:Design) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Related around improvements in the sidebar: #68270 |
I created an issue for pulling out common components into a central place a while ago, the field list being one of them: #41108 Maybe some of the discussion is relevant for this. |
We are also planning on changing the field list in Lens to use an accordion: #67203 |
Related
|
Thinking about this a bit more, I worry about this direction. In Lens, the primary purpose of the field list is informational - you do not take any action from the field list except dragging fields onto the editor space. By contrast in Discover users configure data table from the field list. I think we should be careful to keep that in mind in design and make sure actions are not more complex. For example, I think pushing "add" button to select the field for table into a flyout is a mistake - it's always harder to click those. |
The token icon carries information - it's different depending on the type of the field. But maybe it can change to a plus on hover? |
To reiterate some of @andreadelrio's thoughts: We would only move the "Add as column" button to the popover IF we could implement drag and drop to add to add the fields to the table. Otherwise, yes we will still need to implement an "Add" button directly on the field name for quick adding them to the table. I disagree that there are major differences between the Lens and Discover purposes of the fields list. Both:
The only extra action I see that Discover adds is the ability to "Visualize" which just starts a chart base on that field and not sure how often that is currently used today. @mdefazio Your idea is intriguing. I think we still need to know that the primary action is for a field. Is it to see the field stats or add it to the table. Whichever it is should be the main click on the whole field item and the secondary option should be a button that appears on hover |
Thanks for clarifying @cchaos I think I missed the connection between drag and drop and the design of the list. That part makes sense to me. To dial into the differences/similarities between Discover and Lens: I agree that those are 2 things user does in both cases, but I think the user's intent and the expectations we set with users are different between these tools. It's not obvious up front that you can add columns to Discover, but in Lens we built the UI around this concept and it is very clear. |
My 2 cents here: for me the primary action is adding a column, I like the hover/focus change to a plus icon. This is a difference to the current behavior, but I think it it's an improvement. Would be very interesting to have some telemetry here. |
Summary
In order to provide users a consistent experience across Kibana, we would like to improve the way we present fields in the left sidebar of Discover. To do so, we will align this feature to what we do in Lens to the extent where it is possible.
Target outcome
Improve the visuals of the Discover sidebar while providing a better experience which is consistent with a similar functionality that already exists in Lens.
Proposed changes - Phase 1
Prototypes and mockups
Figma prototype
https://www.figma.com/proto/4b9NHbsHMrJyWV87vMr0PZ/Fields-list?node-id=69%3A3&viewport=122%2C-146%2C0.38255298137664795&scaling=min-zoom (open in Figma desktop app to get images loading properly)
Potential challenges
What about drag and drop?
As the implementation of this functionality requires engineering resources that might not be available in the near future, we think this functionality could be implemented after Phase 1. For this reason, the styling of Discover and Lens should not be identical so as to not lead the user to believe that drag and drop is available in both applications.
Placing the Add button inside a popover would make it be one additional click away. As an alternative to this, we could keep the Add button to the right of the field name. Note that the one disadvantage of this is that it increases the chances of the field name having to wrap into multiple lines.
Phase 2
EuiDataGrid
in Discover we could get rid of the “Selected fields” section and useEuiDataGrid
to remove fields from the table.The text was updated successfully, but these errors were encountered: