Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate feature ID and alerts with alerting consumer to alerts #68994

Closed
gmmorris opened this issue Jun 12, 2020 · 4 comments · Fixed by #69982
Closed

Migrate feature ID and alerts with alerting consumer to alerts #68994

gmmorris opened this issue Jun 12, 2020 · 4 comments · Fixed by #69982
Assignees
@gmmorris
Labels
blocker Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0

Comments

@gmmorris
Copy link
Contributor

gmmorris commented Jun 12, 2020 •
edited
Loading

Following this change https://github.com/elastic/kibana/pull/66838/files?file-filters%5B%5D=.tsx#diff-11975cae1d4e0e055bfedd5944183967R442 all Alerts created before 7.9 will break due to their consumer being the old alerting name instead of the new alerts name.

This will likely need to be addressed through a migration in 7.9.
@gmmorris gmmorris added blocker Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0 labels Jun 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris mentioned this issue Jun 12, 2020
Merged
6 tasks
@legrego legrego mentioned this issue Jun 12, 2020
Open
@gmmorris
Copy link
Contributor Author

gmmorris commented Jun 15, 2020 •
edited
Loading

After chatting with @mikecote we've decided to revert the change to the consumer field and the Feature ID - it'll remain alerting until we know how best to address the migration.

This means that the alerts won't break in 7.9, but we'll need to address this in the future

@gmmorris gmmorris changed the title All alerts from 7.7 and 7.8 will break on upgrade to 7.9 Migrate feature ID and alerts with alerting consumer to alerts Jun 15, 2020
@gmmorris gmmorris removed the blocker label Jun 15, 2020
@gmmorris
Copy link
Contributor Author

Removed the Blocker label as it is no longer blocking the RBAC work and no longer breaks on 7.9

@gmmorris
Copy link
Contributor Author

Turns out this is a blocker still - as we need this to address the name change in Metrics too.
#67157 (comment)

@gmmorris gmmorris self-assigned this Jun 15, 2020
@gmmorris gmmorris mentioned this issue Jun 16, 2020
Merged
gmmorris added a commit to elastic/node-crypto that referenced this issue Jun 16, 2020
@gmmorris
Added Synchronous apis for encrypt and decrypt
f7a2040 
As part of the work for Kibana Alerting, we need a synchronous way top interact with Encrypted Saved Objects (see elastic/kibana#68994).

This PR adds two new entry points, `encryptSync` and `decryptSync` which are  identical to `encrypt` and `decrypt` but are synchronous.
This was referenced Jun 18, 2020
Merged
Closed
@gmmorris gmmorris mentioned this issue Jun 25, 2020
Merged
7 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmmorris gmmorris

Labels
blocker Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@gmmorris @kobelb @elasticmachine