Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Alerts] Actions variable results_link is incorrect #70659

Closed
rylnd opened this issue Jul 2, 2020 · 5 comments
Closed

[Security Solution][Alerts] Actions variable results_link is incorrect #70659

rylnd opened this issue Jul 2, 2020 · 5 comments
Labels
blocker Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0

Comments

@rylnd
Copy link
Contributor

rylnd commented Jul 2, 2020

This is a blocker that needs to be fixed for 7.9 release.

Both our routes names and the routing mechanisms themselves (hashrouter vs other) were changed recently (#68862), but this generated link was not updated to match.

If possible, this work should prevent a regression on further routing changes.

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@spong
Copy link
Member

spong commented Jul 6, 2020

FYI: The route will be returning to /detections here shortly, so we should be good there. Not sure if the routing mechanism changes will still affect this though.

cc @XavierM as he'll be updating these routes one last time... 🙂

@spong
Copy link
Member

spong commented Jul 9, 2020

Verified this was still an issue in the rename PR (#71142) -- chatted with @XavierM and he has the below fix in a follow-up. Fix is to update kibanaSiemAppUrl from siem to security and remove the #. Stay tuned...

export const getNotificationResultsLink = ({
  kibanaSiemAppUrl = '/app/security',
  id,
  from,
  to,
}: {
  kibanaSiemAppUrl?: string;
  id: string;
  from?: string;
  to?: string;
}) => {
  if (from == null || to == null) return '';
  return `${kibanaSiemAppUrl}/detections/rules/id/${id}?timerange=(global:(linkTo:!(timeline),timerange:(from:${from},kind:absolute,to:${to})),timeline:(linkTo:!(global),timerange:(from:${from},kind:absolute,to:${to})))`;
};

@spong
Copy link
Member

spong commented Jul 21, 2020

This will be fixed once #72220 is merged 🙂

@spong
Copy link
Member

spong commented Jul 29, 2020

This ended up being resolved in #72387, closing...

@spong spong closed this as completed Jul 29, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0
Projects
None yet
Development

No branches or pull requests

4 participants