Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] language + fix url action alert #72220

Closed
wants to merge 8 commits into from
Closed

[Security] language + fix url action alert #72220

wants to merge 8 commits into from

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jul 17, 2020 •
edited
Loading

Summary

I took advantage of this PR to introduce a fix for rule alert action and also getting a better UX when you do not have any data in your indices (first-time user) because of the new navigation.

Needs to be updated:

  • The top-level app navigation:

Screen Shot 2020-07-01 at 4 26 12 PM

  • Detection Rules splash screen:
  • @lindseypoli recommends removing the icon entirely from this screen (not replacing with Security logo)
    image

@XavierM XavierM requested review from a team as code owners July 17, 2020 02:43
@XavierM XavierM self-assigned this Jul 17, 2020
@XavierM XavierM requested a review from spong July 17, 2020 02:45
@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.9.0 v8.0.0 labels Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM requested a review from lindseypoli July 17, 2020 04:07
@XavierM XavierM added the bug Fixes for quality problems that affect the customer experience label Jul 17, 2020
cnasikas
cnasikas approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally without any issues.

@patrykkopycinski
Copy link
Contributor

@elasticmachine merge upstream

@XavierM
Copy link
Contributor Author

XavierM commented Jul 20, 2020

waiting on this issue https://github.com/elastic/endpoint-app-team/issues/591 before merging

spong
spong approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the fixes @XavierM!

@spong spong mentioned this pull request Jul 21, 2020
Closed
@patrykkopycinski
Copy link
Contributor

@elasticmachine merge upstream

@FrankHassanabad
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
home 510.6KB +2.0B 510.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong
Copy link
Member

spong commented Jul 29, 2020

Looks like the remainder of this was merged as part of #72387, and now there's just the one text change (which looks to be out of date), so going to close this PR.

@spong spong closed this Jul 29, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@spong spong spong approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@lindseypoli lindseypoli Awaiting requested review from lindseypoli

Assignees

@XavierM XavierM

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@XavierM @elasticmachine @patrykkopycinski @FrankHassanabad @kibanamachine @spong @cnasikas @MindyRS