Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Disable the global timepicker if user is using an index pattern without primary time field, and visualizing data without time #72502

Closed
bhavyarm opened this issue Jul 20, 2020 · 7 comments · Fixed by #108052
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Jul 20, 2020

Blocked on #100858

Kibana version: 7.9.0 BC2

Browser version: chrome latest

Describe the bug: If user is using a index pattern which is created without timefilter to create lens viz - lens app displays the global timepicker. But the visualization itself displays all the documents in that index pattern.

Though this is behaving as intended - having the time picker makes the user think that, user can filter the docs based on the time field.

Steps to reproduce:

  1. Create an index pattern without specifying a timefilter.
  2. Click on visualize->create->lens->pick the index pattern without the timefilter
  3. Lens displays the global time picker

Expected behavior: Lens shouldn't display the global time picker (or let the user know whats happening)

Screenshots (if relevant):
results_don't_change

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Feature:Lens labels Jul 20, 2020
@bhavyarm
Copy link
Contributor Author

CC @wylieconlon

@wylieconlon wylieconlon changed the title Lens should disable(?) the global timepicker if user is using an index pattern without timefilter [Lens] Disable the global timepicker if user is using an index pattern without primary time field, and visualizing data without time Jul 20, 2020
@wylieconlon wylieconlon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 removed the bug Fixes for quality problems that affect the customer experience label Jul 21, 2020
@wylieconlon wylieconlon added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Dec 22, 2020
@wylieconlon
Copy link
Contributor

Recategorizing this as a minor bug because this used to work correctly, but now it doesn't

@timroes
Copy link
Contributor

timroes commented Jan 11, 2021

I am uncertain about the bug behavior in general here. Since Lens does support binding any date field to the time picker, by using it in the visualization (whether the index has a default time field or not), we need the time picker in case a field is bound. What do we think is the correct behavior here? Make sure we're only enabling the date picker, as soon as the index pattern either has a time field OR a time field got dropped into the visualization (that is bound to the timepicker, i.e. used in a date histogram)?

@flash1293
Copy link
Contributor

What do we think is the correct behavior here? Make sure we're only enabling the date picker, as soon as the index pattern either has a time field OR a time field got dropped into the visualization (that is bound to the timepicker, i.e. used in a date histogram)?

I think this behavior would make sense. As soon as it can be used, it will become active.

@flash1293 flash1293 self-assigned this Jun 22, 2021
@flash1293
Copy link
Contributor

I looked into this and we could implement this similar to showNoDataPopover, but it will become much easier once #100858 lands because by then it will be a simple selector on the state instead of passing it up from the editor frame to the app in a weird way.

Let's wait until this is merged before fixing this bug.

@flash1293 flash1293 removed their assignment Jun 22, 2021
@timductive timductive added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 20, 2021
@timroes timroes added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed blocked impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 30, 2021
@mbondyra mbondyra self-assigned this Aug 4, 2021
@mbondyra
Copy link
Contributor

mbondyra commented Aug 4, 2021

Reserving for mob-programming session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
7 participants