Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show "explore underlying data" action if no access to Discover #72838

Closed
Tracked by #71854
Dosant opened this issue Jul 22, 2020 · 2 comments · Fixed by #73017
Closed
Tracked by #71854

Don't show "explore underlying data" action if no access to Discover #72838

Dosant opened this issue Jul 22, 2020 · 2 comments · Fixed by #73017
Assignees
@streamich
Labels
bug Fixes for quality problems that affect the customer experience Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 22, 2020

Kibana version: 7.9 BC2
Describe the bug:

New action introduced in #69368 shouldn't be shown if no access to Discover App

Screenshots (if relevant):

This is how navigation looks like if case no access to discover:

Screenshot 2020-07-22 at 14 52 16

Part of #71854

cc @streamich
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort Team:AppArch impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant self-assigned this Jul 22, 2020
@Dosant Dosant changed the title Don't show "explore underlying data" actions if not access to Discover Don't show "explore underlying data" actions if no access to Discover Jul 22, 2020
@Dosant Dosant changed the title Don't show "explore underlying data" actions if no access to Discover Don't show "explore underlying data" action if no access to Discover Jul 22, 2020
@streamich streamich mentioned this issue Jul 22, 2020
Open
26 tasks
@flash1293
Copy link
Contributor

There is the same issue with the kibana_dashboard_only_user which is handled separately (but should be considered as part of the fix for this issue as well). If it's active, kibanaLegacyStart.dashboardConfig.getHideWriteControls returns true. This integration can be removed with 8.0

@streamich streamich mentioned this issue Jul 23, 2020
Merged
@streamich streamich assigned streamich and unassigned Dosant Jul 23, 2020
@streamich streamich mentioned this issue Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
bug Fixes for quality problems that affect the customer experience Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 don't show actions if Discover app is disabled
4 participants
@flash1293 @Dosant @streamich @elasticmachine