Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 don't Explore data action in dashboard_only mode #73010

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix: 🐛 don't Explore data action in dashboard_only mode #73010

merged 1 commit into from
Jul 23, 2020

Conversation

streamich
Copy link
Contributor

Addresses #72838 (comment)

@streamich streamich requested a review from a team July 23, 2020 08:50
@streamich streamich added bug Fixes for quality problems that affect the customer experience Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:fix Team:AppArch v7.10.0 v7.9.1 v8.0.0 labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich requested a review from flash1293 July 23, 2020 08:51
Dosant
Dosant approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test

flash1293
flash1293 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in firefox, works as expected. LGTM

@streamich streamich merged commit 8f8cba5 into elastic:master Jul 23, 2020
@streamich streamich changed the title fix: 🐛 don't show action in dashboard_only mode fix: 🐛 don't Explore data action in dashboard_only mode Jul 23, 2020
This was referenced Jul 23, 2020
Merged
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
discoverEnhanced 27.0KB +339.0B 26.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

streamich added a commit that referenced this pull request Jul 23, 2020
@streamich
fix: 🐛 don't show action in dashboard_only mode (#73010) (#73027)
cc8672c
streamich added a commit that referenced this pull request Jul 23, 2020
@streamich
fix: 🐛 don't show action in dashboard_only mode (#73010) (#73026)
a11862c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:fix v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@streamich @elasticmachine @kibanamachine @flash1293 @Dosant