Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins using server.host default 0.0.0.0 broken on Windows #7569

Closed
w33ble opened this issue Jun 28, 2016 · 6 comments
Closed

Plugins using server.host default 0.0.0.0 broken on Windows #7569

w33ble opened this issue Jun 28, 2016 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@w33ble
Copy link
Contributor

w33ble commented Jun 28, 2016

Kibana binds to 0.0.0.0 by default. This creates an issue for Windows users.

On Unix, 0.0.0.0 is a valid hostname that you can make requests to directly. However, on Windows, that's not true - it binds to any address on the machine, but 0.0.0.0 is not a valid hostname.

So, any part of Kibana, or any plugin, trying to use server.host to craft a request will fail. This is evidenced in Reporting, as reported in #7338

Elasticsearch changed their default binding from 0.0.0.0 to 127.0.0.1 a while back, perhaps we should do the same. It's a simple change and a confirmed fix for this issue.

@w33ble w33ble added bug Fixes for quality problems that affect the customer experience P1 labels Jun 28, 2016
@jbudz
Copy link
Member

jbudz commented Jun 28, 2016

Related #7196

@w33ble
Copy link
Contributor Author

w33ble commented Jul 1, 2016

Note that this will be an issue in the 4.x branch as well...

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Aug 25, 2016

#7196 has been fixed for 5.X. That change in default would address this issue.

I'm not sure if we want to backport this, since it changes the default behavior. IMO, we assign a 5.X fix version for this, and not backport it.

@w33ble @jbudz @epixa what do you think? we close this as fixed for 5.X, and not backport?

@thomasneirynck thomasneirynck self-assigned this Aug 25, 2016
@epixa
Copy link
Contributor

epixa commented Aug 25, 2016

I think you're right. This is a BC break, so it's not something we can backport.

@epixa
Copy link
Contributor

epixa commented Aug 25, 2016

@w33ble If this causes an issue with reporting on windows, then we need to make sure to draw attention to it in the 2.4 reporting docs.

@thomasneirynck
Copy link
Contributor

By changing the default to localhost, this issue is avoided for Windows. Only applies for 5.x and onward (see #8010).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

4 participants