Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Proposal: Support multiple policy templates per package #75853

Closed
ruflin opened this issue Aug 25, 2020 · 5 comments
Closed
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ruflin
Copy link
Member

ruflin commented Aug 25, 2020

In the Ingest Manager when configuring an integration package, the UI is built based on the policy template in the package (currently called config_templates. In the package, an array of policy_templates is supported but only one is support in Kibana. This issue is to discuss the support for multiple policy templates.

Use case

Having support for multiple policy templates allows creators of packages to offer different default configs to be selected by the user. In the case of the Kafka, the user could select if he wants to monitor partitions, consumers , producers or brokers and based on the selection gets different configurations options offered. In this case, the package would have 4 different policy templates. Like this only 1 Kafka package is needed, but the user can select which part he wants to monitor and only gets the configuration for what he needs as also the Agents running these configs need to be deployed in different places.

An other potential use case is in the system package to provide different defaults on how much data should be collected.

UI

On the UI side, I would expect that if a package contains more then one policy template, the user is offered a selection of the template with potentially a description on what it contains / how it is used.

image

Behaviour

As soon as a policy is saved for a certain template, the template cannot be adjusted anymore. This is only when creating a new policy.

@ruflin ruflin added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Member Author

ruflin commented Aug 25, 2020

@exekias @jsoriano We discuss this in the past.

@ycombinator I don't think it will need any changes on the package-spec part but good to be aware of it.

@exekias
Copy link
Contributor

exekias commented Aug 25, 2020

Is this the same as #70608?

@ruflin
Copy link
Member Author

ruflin commented Aug 25, 2020

@exekias This feature could be used for data fidelity but the proposal in #70608 is different in that the fidelity is on the dataset level. This policy template selection is also before it is shown what can be collected.

@jen-huang
Copy link
Contributor

Closing in favor of #93315 to support granular integrations - aka multiple policy templates 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants