Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the @kbn/std package #76925

Closed
pgayvallet opened this issue Sep 8, 2020 · 5 comments · Fixed by #77329
Closed

Create the @kbn/std package #76925

pgayvallet opened this issue Sep 8, 2020 · 5 comments · Fixed by #77329
Labels
discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Sep 8, 2020

We are currently extracting some code from core to their own packages. Some of this code was using the src/core/utils module. In addition, some package were importing (js) utils from legacy that were moved to core and migrated to typescript, and importing core code from package creates a lot of problems.

This issue is to discuss moving all these utility functions to a new @kbn/std package to address these two issues.

see #76874 (comment) and #76397 (comment) for more context.

Does anyone see any problem, or reasons not to do so?

@pgayvallet pgayvallet added discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor

I actually recently started working on #76518 which introduces a kbn/utils package (do not review, in process of making major changes). For the same reason that you found, we really need a place to have utilities that are used across packages and plugins. My thought is we can use kbn/utils and break things out if it makes sense.

@joshdover
Copy link
Contributor

I think the modules in src/core/utils and what you're working on in #76518 are a bit different. With a few exceptions, the src/core/utils are mostly more like lodash than anything else. I wonder if we should put these truly generic utilities into something like @kbn/std as a "standard library" of sorts and leave the Kibana-specific bits in @kbn/utils.

@tylersmalley
Copy link
Contributor

@joshdover I see -- Yeah, that makes sense to me.

@tylersmalley tylersmalley changed the title Create the @kbn/utils package Create the @kbn/std package Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants