Move core config service to `kbn/config` package #76874

pgayvallet · 2020-09-07T13:48:21Z

Summary

What the PR does:

Extract src/core/logging types and the Logger mock to a new @kbn/logging package.
Extract the whole src/core/config code (except core deprecations for now) into a new @kbn/config package.
Adapt Env type, and mostly Env.createDefault, to now explicitly pass the repoRoot parameter. This is mostly driven by test needs, and caused by the fact that we can no longer require the package.json file and now need to use the REPO_ROOT constant instead.

Regarding Env changes: I know that #76518 is suppose to address the issue I had to resolve here, but this is mostly impacting test files (the only production code change is in bootstrap), so I think this is acceptable if we don't want to loose to much time. We still can 'revert' the Env.createDefault signature change once #76518 lands if it fully solves our issues.

What part of #76003 is not addressed in this PR

Moving core services config schemas, deprecations and associated types to @kbn-config
Adding sugar utility to @kbn-config to easily instanciate a configured ConfigService to be used from outside of the platform environment.

Moving the schemas may be non trivial depending on the coupling with the equivalent types. As the PR is already big and got some significant structural changes, so I would like to handle this in a follow-up, if this is alright with everyone.

What is outside of the scope of the PR:

Moving core logging system implementation to @kbn/logging

This is outside of the scope of #76003, and even if we know we want this, it's currently blocked by the legacy appender, so doing it after the legacy logging has been removed would really facilitate that.

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

pgayvallet

This is WIP, and this PR is only the first step (it 'just' moves the config service code to a package, does not move schemas yet, nor allow consumers to easily create a configured config service), but

Before going any further, some important points and questions. The most important ones are probably:

How to solve the logging module import from the now-in-package config service Move core config service to kbn/config package #76874 (comment)
The effect on the generated doc to have this code moved into a package Move core config service to kbn/config package #76874 (comment)
The way we now expose the mocks / test utils from the package Move core config service to kbn/config package #76874 (comment)
Importing the package.json from the env.ts file / using REPO_ROOT breaks tests mocking the fs package Move core config service to kbn/config package #76874 (comment)

pgayvallet · 2020-09-07T13:50:51Z

packages/kbn-config/README.md

+`@kbn/config-schema` is a TypeScript library inspired by Joi and designed to allow run-time validation of the
+Kibana configuration entries providing developers with a fully typed model of the validated data.


need to add proper readme once this is finished.

This reference to @kbn/config-schema is rather confusing. Isn't it? Let's remove it

packages/kbn-config/package.json

packages/kbn-config/src/legacy/legacy_object_to_config_adapter.ts

pgayvallet · 2020-09-07T14:00:23Z

packages/kbn-config/src/logging.ts

+export type LoggingConfigType = any;
+
+export type LogLevel = any;
+export type LogMeta = any;
+
+export interface LogRecord {
+  timestamp: Date;
+  level: LogLevel;


This is the first big pain point of the PR. The config service relies on the logger service, and tests depends on the logging mocks. At first I wanted to duplicate the interface of Logger and LoggerFactory, but of course they relies on lot of other types from the core/server/logging module, and that doesn't solves the mock class issue.

I don't really see any other option than creating a @kbn/logging package here... 'Good' new is that it is the only service config depends on. But I still don't really like that, because I'm afraid we will be ending with a package per core service...

wdyt?

I don't really see any other option than creating a @kbn/logging package here.

Maybe this isn't such a bad idea. Without such a package we have to duplicate the logging interface in other packages. For example, ToolingLog in
https://github.com/elastic/kibana/tree/ab226f02ae12f0f8a2ec1ff5ba604569cd8d4b68/packages/kbn-dev-utils/src/tooling_log
It might be not that simple though. The logging service consumes the config service, so we would have to decouple them.

The logging service consumes the config service, so we would have to decouple them.

I forget that CoreContext had a reference to the config service. However the LoggingService doesn't seems like it is using it. Or did I overlook a usage somewhere?

ok, I don't see it's used anywhere

Would it make sense or be more convenient to mix these two things into the same package? While they're mostly separate concerns, I suspect most usages of config will also want to use logging. Rather than trying to pull this all apart now, maybe just keeping them together in a @kbn/base package would be a good practical step for now.

I'm not sure it would really be easier to have these two things in the same package. The only logger->config coupling is via the coreContext type, and this can probably be adapted as the logger service does not actually uses it.

I think having two package would avoid to introduce more coupling into these things if/when we decide to split them in distinct packages.

Created #77149 as a POC of creating the logging package. If that's acceptable, I'll reintegrate the changes in this PR.

pgayvallet · 2020-09-07T14:02:59Z

packages/kbn-config/src/utils/get.ts

+export function get<CFG extends { [k: string]: any }>(obj: CFG, path: string[] | string): any {
+  if (typeof path === 'string') {
+    if (path.includes('.')) {
+      throw new Error('Using dots in `get` with a string is not allowed, use array instead');
+    }
+
+    return obj[path];


Another issue moving this code to a package: It was using the get, unset and getFlattenedObject utils defined in the src/core/utils module.

I duplicated them for now. I feel like the proper solution would be to move all the src/core/utils folder to a package, either an already existing one (not sure which...), or a new one.

wdyt?

I've already faced the same problem. #76397 (comment)
I'm not a fan of utils, but it seems to be the pragmatic step. It would be great to discuss it with the @elastic/kibana-operations

Created #76925

Left a comment in #76925, but I'd prefer a @kbn/std package for lodash-like utilities.

I also think copying for now is totally fine. We don't need to necessarily create that package until we have a need in severl places (which maybe we already do)

Yea, that's not a blocker. having the issue to track is probably good enough for now.

packages/kbn-config/tsconfig.json

pgayvallet · 2020-09-07T14:05:44Z

src/core/server/config/index.ts

  ConfigDeprecationFactory,
-  coreDeprecationProvider,
-} from './deprecation';
-
-export { EnvironmentMode, PackageInfo } from './types';
+  EnvironmentMode,
+  PackageInfo,
+  LegacyObjectToConfigAdapter,
+} from '@kbn/config';


I'm re-exporting from the new package all the things that were previously in this module. That felt like the most pragmatic approach. Not sure how this behave with the api-extractor though.

Not sure how this behave with the api-extractor though.

AFAIK api-extractor keeps it as it's declared microsoft/rushstack#1791

pgayvallet · 2020-09-07T14:10:35Z

packages/kbn-config/src/index.ts

+// mocks
+export { configMock } from './config.mock';
+export { configServiceMock } from './config_service.mock';
+export { rawConfigServiceMock } from './raw/raw_config_service.mock';
+export { getEnvOptions } from './__mocks__/env';


As these mocks are used in core, I had to expose them on the package's entrypoint. This feels wrong, but I think creating an additional @kbn/config-mocks package is overkill, wdyt?

I couldn't find a way to have something like import { rawConfigServiceMock } from '@kbn/config/mocks', as I was forced to do import { rawConfigServiceMock } from '@kbn/config/target/out/mocks'. Maybe someone has more knowledge than me on npm packages?

Our nodejs version doesn't support exports https://nodejs.org/docs/latest-v12.x/api/esm.html#esm_main_entry_point_export
We could emit *.js files next to *.ts and ignore them in .gitignore.
@elastic/kibana-operations any other ideas?

Since we build in place and can't produce the JS at the root of the module, I don't see any other alternative. Sounds like the best thing right now would be to use target in the import until we upgrade to v12.

pgayvallet · 2020-09-07T14:14:14Z

packages/kbn-config/src/env.ts

-const pkg = require('../../../../package.json');
+const pkg = require('../../../package.json');


Now that this is in a package, these hardcoded requires won't work anymore, as the compiled file in node_modules it not at the same place, or depth, than in the source. I think we don't have any other option than using the REPO_ROOT constant from @kbn/dev-utils (same lower in file)

Note that as REPO_ROOT is an absolute path, we won't be able to require it and we'll have to fallback to read and parse the file 'manually'.

The mocking (see packages/kbn-config/src/env.test.mocks.ts) will have to be adapted too.

EDIT: done. Fun fact, tests that are mocking the fs package are now exploding because REPO_ROOT is computed at module load.

kibana/packages/kbn-dev-utils/src/repo_root.ts

Lines 47 to 59 in 7b4278d

while (true) {

if (isKibanaDir(cursor)) {

break;

}

const parent = Path.dirname(cursor);

if (parent === rootDir) {

throw new Error(`unable to find kibana directory from ${startDir}`);

}

cursor = parent;

}

export const REPO_ROOT = cursor;

It's quite bad because it's not only impacting core tests, some xpack tests are also failing because of that.

Commented on this here: #76874 (comment)

#76518 is almost ready for review including resolving the tests mocking fs by being explicit about the actual files they wish to mock -

pgayvallet · 2020-09-07T20:01:40Z

src/core/server/server.api.md

+import { ConfigDeprecation } from '@kbn/config';
+import { ConfigDeprecationFactory } from '@kbn/config';
+import { ConfigDeprecationLogger } from '@kbn/config';
+import { ConfigDeprecationProvider } from '@kbn/config';


Another issue moving these to a package: The doc files are no longer generated, as they are imported/exported from the package. See 545c867. Not sure if we have a solution for that

I don't think we do. @kbn/config becomes an external package for src/core, so api-extractor terminates traversing at this point. ~~Investigation required to understand whether we can link types between packages.~~ It's not supported microsoft/rushstack#1596

So by extracting config, and logging outside of core, we basically are loosing the documentation for their types.

Would generating doc from these package solve this? I guess core and @kbn/xxx generated doc would not be able to link to each other...

I guess core and @kbn/xxx generated doc would not be able to link to each other...

Right, in the issue I attached discussed that this use-case is not supported out-of-the-box. We might have to contribute to api-extractor to support this. Even a link to @kbn/xxx package would be good start.

Should we create an issue to contribute to api-extractor ? @joshdover

Created #77529 as a discussion issue

packages/kbn-config/package.json

packages/kbn-config/tsconfig.json

packages/kbn-config/src/env.ts

…fig-package

…ackage

… production code

…fig-package

pgayvallet

The only major downside from this PR is the impact on the api-extractor documentation that does not work with re-exports or references to types from another package. I still feel like it shouldn't be considered blocker, and I think the solution would be to fix the extractor instead at some point (see #76874 (comment)), as the 'move to package' approach is still, in my opinion, the only valid one if we want to start exposing services such as config and logging to code outside of the core platform.

pgayvallet · 2020-09-14T10:01:38Z

docs/development/core/server/kibana-plugin-core-server.pluginconfigdescriptor.deprecations.md

-Provider for the [ConfigDeprecation](./kibana-plugin-core-server.configdeprecation.md) to apply to the plugin configuration.
+Provider for the  to apply to the plugin configuration.


Links to types moved in the logging and config packages do no longer work. Not sure there is anything we can do unfortunately.

pgayvallet · 2020-09-14T10:03:12Z

src/plugins/data/public/public.api.md

+import { Logger } from '@kbn/logging';
+import { LogMeta } from '@kbn/logging';


@elastic/kibana-app-arch The additional imports in src/plugins/data/public/public.api.md and src/plugins/data/server/server.api.md should be the only changes impacting you

pgayvallet · 2020-09-14T10:04:27Z

src/core/server/server.api.md

+    // Warning: (ae-unresolved-link) The @link reference could not be resolved: Reexported declarations are not supported
    readonly configPath: ConfigPath;


Another downside of moving the types to a package regarding documentation

pgayvallet · 2020-09-14T10:07:50Z

src/core/server/logging/logger.mock.ts

-export const loggerMock = {
-  create: createLoggerMock,
-};
+export { loggerMock, MockedLogger } from '@kbn/logging/target/mocks';


I kept this file and just re-exported the mock that got moved in the logging package to avoid adding 100+ import changes to the diff. Overall, I think it's going to be a good practice to have package-reexporting modules if we move things out of core.

pgayvallet · 2020-09-14T10:11:32Z

src/core/server/bootstrap.ts

+  // `bootstrap` is exported from the `src/core/server/index` module,
+  // meaning that any test importing, implicitly or explicitly, anything concrete
+  // from `core/server` will load `dev-utils`. As some tests are mocking the `fs` package,
+  // and as `REPO_ROOT` is initialized on the fly when importing `dev-utils` and requires
+  // the `fs` package, it causes failures. This is why we use a dynamic `require` here.
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  const { REPO_ROOT } = require('@kbn/dev-utils');
+
+  const env = Env.createDefault(REPO_ROOT, {


Self explanatory comment. May be resolved by #76518. See main issue description for more info.

packages/kbn-logging/src/utils/assert_never.ts

mshustov · 2020-09-14T12:06:15Z

packages/kbn-config/README.md

+`@kbn/config-schema` is a TypeScript library inspired by Joi and designed to allow run-time validation of the
+Kibana configuration entries providing developers with a fully typed model of the validated data.


This reference to @kbn/config-schema is rather confusing. Isn't it? Let's remove it

mshustov · 2020-09-14T12:10:46Z

packages/kbn-logging/README.md

+
+Base types for the kibana platform logging system.
+
+Note that this package currently only contains logging types. The only concrete implementation


What prevents us from moving the implementation to the package? Should we create an issue to move the implementation to the package?

The base classes such as BaseLogger and LoggerAdapter could be moved without any issue.

The main issue is about the appenders, that are currently importing code from legacy, which are themselves importing a whole lot of dependencies that we can't extract to the new package.

kibana/src/core/server/logging/appenders/appenders.ts

Lines 24 to 27 in 92243ba

import {

LegacyAppender,

LegacyAppenderConfig,

} from '../../legacy/logging/appenders/legacy_appender';

We would need to adapt the Appenders class to allow registration of appenders + their associated config schema. That way, we could have the base appenders in the package, and the legacy appender only defined and registered inside core. But this is not trivial, as the schema registration would have to be performed before validating the actual configuration file. This is why I'm keeping this for later.

packages/kbn-logging/README.md

packages/kbn-logging/package.json

mshustov · 2020-09-14T12:51:56Z

src/core/server/plugins/integration_tests/plugins_service.test.ts

@@ -17,15 +17,16 @@
 * under the License.
 */

+// must be before mocks imports to avoid conflicting with `REPO_ROOT` accessor.
+import { REPO_ROOT } from '@kbn/dev-utils';


The package is stateful and the wrong import order blows out the tests? That's not good 😞

Yea. The package is stateful + it depends on fs.readFileSync for the REPO_ROOT initialization, so it's really awkward ina few testing scenarios. #76518 is supposed to adapt the tests mocking the whole fs package to only mock specific files to address this...

mshustov · 2020-09-14T13:06:08Z

src/core/server/server.api.md

+import { ConfigDeprecation } from '@kbn/config';
+import { ConfigDeprecationFactory } from '@kbn/config';
+import { ConfigDeprecationLogger } from '@kbn/config';
+import { ConfigDeprecationProvider } from '@kbn/config';


Should we create an issue to contribute to api-extractor ? @joshdover

packages/kbn-config/package.json

packages/kbn-config/src/env.ts

packages/kbn-logging/tsconfig.json

…fig-package

spalger · 2020-09-15T16:41:10Z

packages/kbn-config/README.md

@@ -0,0 +1,3 @@
+# `@kbn/config` — Kibana configuration file loader
+
+This package contains the configuration service used to load and read the kibana configuration file


Can you include some basic usage information here?

Yea, in the follow-up, as there is currently no way to properly use the configuration service that has been extracted. (This is only step 1 of #76003, PR would have been too big otherwise)

…fig-package

kibanamachine · 2020-09-16T07:11:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b77c901

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
core	562	-1	563

async chunks size

id	value	diff	baseline
enterpriseSearch	430.2KB	+45.0B	430.1KB

page load bundle size

id	value	diff	baseline
core	1.2MB	-51.0B	1.2MB
upgradeAssistant	64.8KB	+45.0B	64.8KB
total		-6.0B

distributable file count

id	value	diff	baseline
default	45905	+301	45604
oss	27728	+468	27260
total		+769

History

💚 Build #74582 succeeded c0abb98
💔 Build #74563 failed fe0fcc5
💚 Build #74474 succeeded 9997809
💔 Build #74462 failed 8828c18
💚 Build #74424 succeeded 4d874ef

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* move deprecations and raw loader to package * move config service to package * start to adapt the usages * adapt yet more usages * update generated doc * move logging types to `@kbn/logging` * update generated doc * add yarn.lock symlink * merge @kbn-logging PR * adapt Env.createDefault * update generated doc * remove mock exports from the main entrypoint to avoid importing it in production code * use dynamic require to import `REPO_ROOT` from bootstrap file * move logger mock to kbn-logging package * address review comments * import PublicMethodOf from kbn/utility-types * fix import conflict * update generated doc * use the @kbn/std package * update generated doc * adapt plugin service mock

…s-for-710 * 'master' of github.com:elastic/kibana: (95 commits) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) [@kbn/utils] Adds missing dependency (elastic#77536) Add the Enterprise Search logo to the Overview search result (elastic#77514) [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482) [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402) Adds @kbn/utils package (elastic#76518) Map layout changes (elastic#77132) [Security Solution] [Detections] EQL Rule Creation (elastic#76831) Adding test user to maps tests under documents source folder (elastic#77245) Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx

* move deprecations and raw loader to package * move config service to package * start to adapt the usages * adapt yet more usages * update generated doc * move logging types to `@kbn/logging` * update generated doc * add yarn.lock symlink * merge @kbn-logging PR * adapt Env.createDefault * update generated doc * remove mock exports from the main entrypoint to avoid importing it in production code * use dynamic require to import `REPO_ROOT` from bootstrap file * move logger mock to kbn-logging package * address review comments * import PublicMethodOf from kbn/utility-types * fix import conflict * update generated doc * use the @kbn/std package * update generated doc * adapt plugin service mock

* master: (55 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (54 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (76 commits) Fixing service maps API test (elastic#77586) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) ...

pgayvallet added 3 commits September 7, 2020 11:38

move deprecations and raw loader to package

29d8dfc

move config service to package

8269fa0

start to adapt the usages

aa32943

pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 labels Sep 7, 2020

pgayvallet commented Sep 7, 2020

View reviewed changes

pgayvallet added 2 commits September 7, 2020 20:14

adapt yet more usages

7d79ca2

update generated doc

545c867

pgayvallet commented Sep 7, 2020

View reviewed changes

mshustov reviewed Sep 8, 2020

View reviewed changes

packages/kbn-config/package.json Outdated Show resolved Hide resolved

mshustov reviewed Sep 8, 2020

View reviewed changes

packages/kbn-config/tsconfig.json Outdated Show resolved Hide resolved

pgayvallet mentioned this pull request Sep 8, 2020

Create the @kbn/std package #76925

Closed

joshdover reviewed Sep 8, 2020

View reviewed changes

packages/kbn-config/src/env.ts Outdated Show resolved Hide resolved

tylersmalley mentioned this pull request Sep 9, 2020

Adds @kbn/utils package #76518

Merged

move logging types to @kbn/logging

92243ba

pgayvallet mentioned this pull request Sep 10, 2020

Create @kbn/logging package #77149

Closed

7 tasks

pgayvallet added 11 commits September 10, 2020 13:22

update generated doc

c965735

add yarn.lock symlink

c016d45

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

601173c

…fig-package

Merge branch 'kbn-xxx-kbn-logger-package' into kbn-76003-kbn-config-p…

1086b29

…ackage

merge @kbn-logging PR

67d6575

adapt Env.createDefault

f825d42

update generated doc

b2dbebe

remove mock exports from the main entrypoint to avoid importing it in…

3c1fac0

… production code

use dynamic require to import REPO_ROOT from bootstrap file

e1152a1

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

ba6b703

…fig-package

move logger mock to kbn-logging package

0bb5c5d

pgayvallet commented Sep 14, 2020

View reviewed changes

mshustov approved these changes Sep 14, 2020

View reviewed changes

lukeelmers approved these changes Sep 14, 2020

View reviewed changes

pgayvallet added 9 commits September 15, 2020 10:43

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

b0c9209

…fig-package

address review comments

d9069c3

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

d1fe014

…fig-package

import PublicMethodOf from kbn/utility-types

7999389

fix import conflict

29e8ae6

update generated doc

4d874ef

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

fb4bc59

…fig-package

use the @kbn/std package

8828c18

update generated doc

9997809

spalger reviewed Sep 15, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

fe0fcc5

…fig-package

pgayvallet mentioned this pull request Sep 15, 2020

Adapt api-extractor to allow generating documentation from re-exported types #77529

Closed

pgayvallet added 3 commits September 15, 2020 21:01

adapt plugin service mock

c80dd02

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

c0abb98

…fig-package

Merge remote-tracking branch 'upstream/master' into kbn-76003-kbn-con…

b77c901

…fig-package

pgayvallet merged commit ab92bbb into elastic:master Sep 16, 2020

pgayvallet mentioned this pull request Sep 16, 2020

[7.x] Move core config service to kbn/config package (#76874) #77575

Merged

pgayvallet mentioned this pull request Mar 22, 2021

Remove circular dependencies between CLI & core #76935

Closed

		`@kbn/config-schema` is a TypeScript library inspired by Joi and designed to allow run-time validation of the
		Kibana configuration entries providing developers with a fully typed model of the validated data.

		const pkg = require('../../../../package.json');
		const pkg = require('../../../package.json');

	while (true) {
	if (isKibanaDir(cursor)) {
	break;
	}

	const parent = Path.dirname(cursor);
	if (parent === rootDir) {
	throw new Error(`unable to find kibana directory from ${startDir}`);
	}
	cursor = parent;
	}

	export const REPO_ROOT = cursor;

		Provider for the [ConfigDeprecation](./kibana-plugin-core-server.configdeprecation.md) to apply to the plugin configuration.
		Provider for the to apply to the plugin configuration.

		import { Logger } from '@kbn/logging';
		import { LogMeta } from '@kbn/logging';

		// Warning: (ae-unresolved-link) The @link reference could not be resolved: Reexported declarations are not supported
		readonly configPath: ConfigPath;


		Base types for the kibana platform logging system.

		Note that this package currently only contains logging types. The only concrete implementation

	import {
	LegacyAppender,
	LegacyAppenderConfig,
	} from '../../legacy/logging/appenders/legacy_appender';

		@@ -0,0 +1,3 @@
		# `@kbn/config` — Kibana configuration file loader

		This package contains the configuration service used to load and read the kibana configuration file

Move core config service to kbn/config package #76874

Move core config service to kbn/config package #76874

Conversation

pgayvallet commented Sep 7, 2020 • edited Loading

Summary

What the PR does:

What part of #76003 is not addressed in this PR

What is outside of the scope of the PR:

Checklist

pgayvallet left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet Sep 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tylersmalley Sep 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Sep 16, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

distributable file count

History

Move core config service to `kbn/config` package #76874

Move core config service to `kbn/config` package #76874

pgayvallet commented Sep 7, 2020 •

edited

Loading

pgayvallet left a comment •

edited

Loading

mshustov Sep 8, 2020 •

edited

Loading

mshustov Sep 8, 2020 •

edited

Loading

pgayvallet Sep 7, 2020 •

edited

Loading

tylersmalley Sep 9, 2020 •

edited

Loading

mshustov Sep 8, 2020 •

edited

Loading

mshustov Sep 8, 2020 •

edited

Loading