Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Enterprise Search logo to the Overview search result #77514

Merged

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Sep 15, 2020

Summary

Adds the Enterprise Search logo for the new Overview page so that it appears in the search results like so:

Side note: we're working on adding some metadata below the page title that will signify which solution/category the result belongs too. In other words, this will soon show Enterprise Search as a subtitle under the Overview text.

Before

Screen Shot 2020-09-15 at 9 38 12 AM

After

Screen Shot 2020-09-15 at 11 26 00 AM

Checklist

Delete any items that are not applicable to this PR.

N/A

@ryankeairns ryankeairns added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 15, 2020
@ryankeairns ryankeairns requested a review from a team September 15, 2020 16:33
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks so much for grabbing this for us!

Random aside, I don't suppose anyone's mentioned the possibility of including a specific title for the search bar? e.g., searchTitle: 'Enterprise Search Overview' vs. just "Overview"? 🤔 No worries if not of course, just me being nosy!

@ryankeairns
Copy link
Contributor Author

🙏 Thanks so much for grabbing this for us!

Random aside, I don't suppose anyone's mentioned the possibility of including a specific title for the search bar? e.g., searchTitle: 'Enterprise Search Overview' vs. just "Overview"? 🤔 No worries if not of course, just me being nosy!

As it stands, we're using the same label that appears in the left navigation. It's an interesting suggestion that I'll track as an option going forward. We envision the search feature evolving over time and it seems likely that further 'customizations' , such as this, could be provided. Thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
enterpriseSearch 22.5KB +32.0B 22.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ryankeairns ryankeairns merged commit 1e00ae7 into elastic:master Sep 15, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 16, 2020
…s-for-710

* 'master' of github.com:elastic/kibana: (95 commits)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  [@kbn/utils] Adds missing dependency (elastic#77536)
  Add the Enterprise Search logo to the Overview search result (elastic#77514)
  [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482)
  [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402)
  Adds @kbn/utils package (elastic#76518)
  Map layout changes (elastic#77132)
  [Security Solution] [Detections] EQL Rule Creation (elastic#76831)
  Adding test user to maps tests under documents source folder  (elastic#77245)
  Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants