Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grok] Fix missing error message in error toasts #77499

Merged
merged 1 commit into from
Sep 16, 2020
Merged

[Grok] Fix missing error message in error toasts #77499

merged 1 commit into from
Sep 16, 2020

Conversation

jloleysens
Copy link
Contributor

Summary

The error toasts have been missing for a while - or at least since the toast notification API may have been updated.

Fixes #77006

How to test

Type in an input and pattern combination that do not match and press simulate. See screenshot for an example 👇🏻.

(Optional) Also test "unexpected errors" by adding a throw new Error('test') line in x-pack/plugins/grokdebugger/public/components/grok_debugger/grok_debugger.js in the simulate function just before line 89. You should see the familiar error notification with details about the error that occurred including stack trace.

Screenshots

Screenshot 2020-09-15 at 16 40 18

Release note

Fixed an issue in the grok debugger where simulation error messages are not being displayed.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@jloleysens jloleysens added Feature:Dev Tools release_note:fix v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 Feature:Grok Debugger Dev Tools Grok Debugger feature v7.9.2 labels Sep 15, 2020
@jloleysens jloleysens requested a review from a team as a code owner September 15, 2020 15:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
grokdebugger 76 +37 39

async chunks size

id value diff baseline
grokdebugger 711.0KB +13.2KB 697.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens requested review from sebelga and removed request for yuliacech September 16, 2020 10:08
sebelga
sebelga approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this fix! 👍

@jloleysens jloleysens merged commit f70aace into elastic:master Sep 16, 2020
@jloleysens jloleysens deleted the grok/fix-toast-error-message branch September 16, 2020 11:00
@jloleysens jloleysens mentioned this pull request Sep 16, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 16, 2020
@jloleysens
[Grok] Fix missing error message in error toasts (elastic#77499)
bc9bc7d
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 16, 2020
@jloleysens
[Grok] Fix missing error message in error toasts (elastic#77499)
8c8a539
@jloleysens jloleysens mentioned this pull request Sep 16, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into alerts/alerting-exempt-rbac-remnant
c051d65 
* master: (55 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
7bfbad5 
* master: (54 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
45a2dd5 
* master: (76 commits)
  Fixing service maps API test (elastic#77586)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  ...
jloleysens added a commit that referenced this pull request Sep 17, 2020
@jloleysens
[Grok] Fix missing error message in error toasts (#77499) (#77597)
ad7b40c
jloleysens added a commit that referenced this pull request Sep 17, 2020
@jloleysens
[Grok] Fix missing error message in error toasts (#77499) (#77596)
1e06bf5
@cjcenizal cjcenizal mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
Feature:Dev Tools Feature:Grok Debugger Dev Tools Grok Debugger feature release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulating grok debug pattern gives no result, empty toaster error
4 participants
@jloleysens @elasticmachine @kibanamachine @sebelga