Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] avoid moving the aggregation location #78153

Closed
AlonaNadler opened this issue Sep 22, 2020 · 7 comments · Fixed by #78864
Closed

[Lens] avoid moving the aggregation location #78153

AlonaNadler opened this issue Sep 22, 2020 · 7 comments · Fixed by #78864
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@AlonaNadler
Copy link

Describe the feature:
When moving between aggregations in Lens. Sometimes (not all times) the location of the aggregation changes after being clicked

It hurts the users' orientation. I realized something changed but IK wasn't sure what and why. To get expertise in Lens it is better to not move the location of the aggregation

In the gif see how the filter aggregation moves after clicked on.
Sep-22-2020 06-50-39

@AlonaNadler AlonaNadler added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon added the enhancement New value added to drive a business result label Sep 22, 2020
@wylieconlon
Copy link
Contributor

I agree that this is confusing, and I think I'd like to get @cchaos's opinion on how to improve it. The simplest approach is to stop changing the sort order of the functions, but if we do that without changing the styles we will get a "zebra-striping" effect. Maybe the zebra-striping is fine, and we should always keep the sort order the same.

@flash1293
Copy link
Contributor

flash1293 commented Sep 22, 2020

IMHO having a consistent order is more important than grouping the operations by applicability to the current field - the styling should be enough for that.

@flash1293
Copy link
Contributor

@wylieconlon did you move this to "minor bugs" on purpose? Not sure how that matches with the enhancement label :)

@wylieconlon
Copy link
Contributor

@flash1293 I'm not sure what the right way to categorize this is, it's on the border between a bug and enhancement. I'd like to clean it up as soon as possible, potentially before the 7.10 feature freeze.

@cchaos
Copy link
Contributor

cchaos commented Sep 22, 2020

The simplest approach is to stop changing the sort order of the functions, but if we do that without changing the styles we will get a "zebra-striping" effect. Maybe the zebra-striping is fine, and we should always keep the sort order the same.

IMHO having a consistent order is more important than grouping the operations by applicability to the current field - the styling should be enough for that.

Yep! I agree with these comments 💯 !!

@flash1293
Copy link
Contributor

Let's call it a bug and fix it in the fix-it week.

@flash1293 flash1293 added :KibanaApp/fix-it-week bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Sep 23, 2020
@wylieconlon wylieconlon self-assigned this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants