[Lens] Maintain order of operations in dimension panel #78864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
commented
Sep 29, 2020
| @@ -960,12 +960,12 @@ describe('IndexPatternDimensionEditorPanel', () => { | |||
| const items: EuiListGroupItemProps[] = wrapper.find(EuiListGroup).prop('listItems') || []; | |||
|
|
|||
| expect(items.map(({ label }: { label: React.ReactNode }) => label)).toEqual([ | |||
| 'Unique count', | |||
There was a problem hiding this comment.
The tests already covered the behavior of the buttons, so the only change here is to the ordering.
|
The code looks good. Tested in Chrome and it works fine 🆗 I am just wondering that maybe the alphabetic order on the long run might now be enough and we should remember about this one when adding other aggregations. In Visualize we have subcategories for metric aggregations, parent pipeline aggregations and sibling pipeline aggs (picture below). Adding subcategories or at least group by them when sorting would be an improvement.
|
mbondyra
approved these changes
Sep 30, 2020
|
@mbondyra Yes I'm definitely interested in categorizing them! I think it will become obvious once we start adding calculations. |
wylieconlon
pushed a commit
that referenced
this pull request
Sep 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 30, 2020
* master: (97 commits) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) [Enterprise Search][App Search] Credentials Logic updates (elastic#78644) [Monitoring] Disk usage alerting (elastic#75419) [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601) Update content on interstitial page (elastic#78881) chore(NA): include hjson as a prod dependency (elastic#78941) Fix empty meta fields input in Advanced Settings (elastic#78576) [Lens] Maintain order of operations in dimension panel (elastic#78864) Fix plugin doc title (elastic#78880) load apm-rum agent lazily (elastic#78760) [ML] Skip full ML access permission test Optimize charts plugin (elastic#78922) ui_actions service initial docs (elastic#78902) skip failing suite (elastic#78942) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR maintains all the existing behavior except that operations are now displayed in the same order regardless of whether they are considered "compatible" or not. This results in the following behavior:
Closes #78153
Checklist